Date: Sat, 30 Aug 2008 19:21:42 GMT From: Edward Tomasz Napierala <trasz@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 148862 for review Message-ID: <200808301921.m7UJLgYT085110@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=148862 Change 148862 by trasz@trasz_traszkan on 2008/08/30 19:20:50 Backwards binary compatibility wrappers for libc. Affected files ... .. //depot/projects/soc2008/trasz_nfs4acl/lib/libc/posix1e/Makefile.inc#9 edit .. //depot/projects/soc2008/trasz_nfs4acl/lib/libc/posix1e/Symbol.map#8 edit .. //depot/projects/soc2008/trasz_nfs4acl/lib/libc/posix1e/acl_compat.c#1 add .. //depot/projects/soc2008/trasz_nfs4acl/lib/libc/posix1e/acl_delete_entry.c#7 edit .. //depot/projects/soc2008/trasz_nfs4acl/lib/libc/posix1e/acl_get.c#8 edit .. //depot/projects/soc2008/trasz_nfs4acl/lib/libc/posix1e/acl_perm.c#3 edit Differences ... ==== //depot/projects/soc2008/trasz_nfs4acl/lib/libc/posix1e/Makefile.inc#9 (text+ko) ==== @@ -5,6 +5,7 @@ SRCS+= acl_branding.c \ acl_calc_mask.c \ acl_copy.c \ + acl_compat.c \ acl_delete.c \ acl_delete_entry.c \ acl_entry.c \ ==== //depot/projects/soc2008/trasz_nfs4acl/lib/libc/posix1e/Symbol.map#8 (text) ==== @@ -21,15 +21,12 @@ acl_get_link_np; acl_get_fd; acl_get_fd_np; - acl_get_perm_np; acl_get_permset; acl_get_qualifier; acl_get_tag_type; acl_init; acl_dup; - acl_add_perm; acl_clear_perms; - acl_delete_perm; acl_set_file; acl_set_link_np; acl_set_fd; @@ -70,14 +67,17 @@ FBSD_1.1 { acl_add_flag_np; + acl_add_perm; acl_clear_flags_np; acl_create_entry_np; acl_delete_entry_np; acl_delete_flag_np; + acl_delete_perm; acl_get_brand_np; acl_get_extended_np; acl_get_flag_np; acl_get_flagset_np; + acl_get_perm_np; acl_is_trivial_np; acl_set_extended_np; acl_set_flagset_np; ==== //depot/projects/soc2008/trasz_nfs4acl/lib/libc/posix1e/acl_delete_entry.c#7 (text+ko) ==== @@ -45,8 +45,6 @@ * draft ACLs. In POSIX, there may be only one entry for the particular * user or group. In NFSv4 ACL, there may be any number of them. We're * trying to be more specific here in that case. - * - * XXX: The proper way would be to remove them by entry number. */ switch (_entry_brand(a)) { case ACL_BRAND_NFS4: ==== //depot/projects/soc2008/trasz_nfs4acl/lib/libc/posix1e/acl_get.c#8 (text+ko) ==== @@ -137,9 +137,6 @@ return (aclp); } -/* - * XXX: Possible binary compatibility problem; acl_perm_t definition changed. - */ int acl_get_perm_np(acl_permset_t permset_d, acl_perm_t perm) { ==== //depot/projects/soc2008/trasz_nfs4acl/lib/libc/posix1e/acl_perm.c#3 (text+ko) ==== @@ -39,9 +39,6 @@ * acl_add_perm() (23.4.1): add the permission contained in perm to the * permission set permset_d */ -/* - * XXX: Possible binary compatibility problem; acl_perm_t definition changed. - */ int acl_add_perm(acl_permset_t permset_d, acl_perm_t perm) { @@ -82,9 +79,6 @@ * acl_delete_perm() (23.4.10): remove the permission in perm from the * permission set permset_d */ -/* - * XXX: Possible binary compatibility problem; acl_perm_t definition changed. - */ int acl_delete_perm(acl_permset_t permset_d, acl_perm_t perm) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808301921.m7UJLgYT085110>