Date: Sun, 14 Aug 2016 22:01:50 -0700 From: Xin Li <delphij@delphij.net> To: Zaphod Beeblebrox <zbeeble@gmail.com> Cc: d@delphij.net, freebsd-fs <freebsd-fs@freebsd.org> Subject: Re: zfs_recovery=1, zdb, mounted pool? Message-ID: <3b1ad8c4-f073-998b-84ed-f906029572ba@delphij.net> In-Reply-To: <CACpH0MdozEdZNQrz%2BbZfAnL-b-QH=Z1sCGxxjAA-4Xia-ZcVrw@mail.gmail.com> References: <CACpH0Md01cwOTpbvaeGgEKWx3atfT8uZ3hAjJRbT4QQqDHShOA@mail.gmail.com> <3a38203a-e397-9695-b147-2fb46fa92d0a@delphij.net> <CACpH0MdozEdZNQrz%2BbZfAnL-b-QH=Z1sCGxxjAA-4Xia-ZcVrw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8BhltCdlINBPOGkaXaUR2rjEMaMk3t0Nn Content-Type: multipart/mixed; boundary="1pN9GAoBnfQJ1Bh3cEgdCVRkHI8hALxOB" From: Xin Li <delphij@delphij.net> To: Zaphod Beeblebrox <zbeeble@gmail.com> Cc: d@delphij.net, freebsd-fs <freebsd-fs@freebsd.org> Message-ID: <3b1ad8c4-f073-998b-84ed-f906029572ba@delphij.net> Subject: Re: zfs_recovery=1, zdb, mounted pool? References: <CACpH0Md01cwOTpbvaeGgEKWx3atfT8uZ3hAjJRbT4QQqDHShOA@mail.gmail.com> <3a38203a-e397-9695-b147-2fb46fa92d0a@delphij.net> <CACpH0MdozEdZNQrz+bZfAnL-b-QH=Z1sCGxxjAA-4Xia-ZcVrw@mail.gmail.com> In-Reply-To: <CACpH0MdozEdZNQrz+bZfAnL-b-QH=Z1sCGxxjAA-4Xia-ZcVrw@mail.gmail.com> --1pN9GAoBnfQJ1Bh3cEgdCVRkHI8hALxOB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 8/14/16 21:46, Zaphod Beeblebrox wrote: > On Sun, Aug 14, 2016 at 7:50 PM, Xin Li <delphij@delphij.net > <mailto:delphij@delphij.net>> wrote: >=20 >=20 >=20 > On 8/14/16 13:04, Zaphod Beeblebrox wrote: > > So... I found 319 of the errno 122 errors by running zdb. My > question is > > this: > > > > Can I run with zfs_recovery=3D1 and have zdb fix these (which are= > free space > > leaked errors) while the system is running? >=20 > No. >=20 > If I was you I would definitely do a full backup to a different pla= ce, > recreate the pool and restore from the backup. >=20 > It's not safe to use your pool as-is, don't do it for everybody's s= ake. >=20 >=20 > So, then, do I start a big bug on this issue? Is there a bug on this > issue? Seriously... it appears to have happened to multiple people. I don't think so -- zfs_recovery is the last resort option that disables certain assertions, which implies that your pool is already damaged beyond repair (i.e. beyond the redundancy margin that ZFS have had built in, e.g. multiple copies of metadata, RAID-Z, etc.), typically as a result of RAM issues. In theory it is possible to rebuild space map and recover the space, but note that space map have sufficient redundancy that, if you have see errors in it that can not be corrected by ZFS's self-healing, it's highly likely that there are much more damage to the pool already. If you don't have a reproduction case for this one that can reliably trigger a leak without hardware issue, I think it would be just a waste of time to file a bug. Cheers, --1pN9GAoBnfQJ1Bh3cEgdCVRkHI8hALxOB-- --8BhltCdlINBPOGkaXaUR2rjEMaMk3t0Nn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJXsUzBAAoJEJW2GBstM+ns4/sQAKGk4r1/OkABoUAZHc+v5HT6 g/0ttoSHFK7jorK/Zz1jNHBG27WhN9eRokBZzy9bGvudjmhvbT0BVGJCzqtBo4yo maghRKiQO/9DL4Wwcy+P7w8tWrZrbEQOz8FKp31WO1NiFCw5Pq782kXwBiMcIG+E z9Up7IHIN77cQCsQUZkfzxMS/ZfiVFXex8glOxuXHAnWWK+1uNl+/62fQeYEN93Y JkXYGVGRrdZKD5gDsr6lGIEUyGCInj/QI5g99q5DfumLaZ016xE2GZmmIZnQbRH9 NKbE8O1abBFRt69eOVi6v1ojXm5RAq7td7OLejYcs/RuKsTYZpZxq1xWOFWB6HV6 ql73SBnnt5R3andKE4gP4xjl+3/eWv+hHVdNtGHmmVjth2rRTtUzDeGIdA0TKpcB haHWB3H3xiJwkKLGiCSVLxaI22v48UcQ0GUR6PMHlyQojjWcyoRnZTKZoNNhu/zM 6ZncKWW3J+D9alNA3VAKWOZ0rkaShyWgvM8GGgHSu2GemiR++rN7OpBj3K6ZIYaD I3yh1V0zULDgOQAfXyIeEovdelZy2aLNwtlKg1/nl2Wn7WU3Jo5Zp9q3BH49ZhAN ZyG1bBCWQI9nckb2LF5JJq9jk5SJfboYrwgL1S9aBCcv0YWyMi1FcxURoaRZbMRM gIZEX4XA6oUympA34CSO =xBiX -----END PGP SIGNATURE----- --8BhltCdlINBPOGkaXaUR2rjEMaMk3t0Nn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3b1ad8c4-f073-998b-84ed-f906029572ba>