From owner-freebsd-net@freebsd.org Wed Sep 18 05:11:13 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7230EF1378 for ; Wed, 18 Sep 2019 05:11:13 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Y7Nw3rWRz3LFw for ; Wed, 18 Sep 2019 05:11:12 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-pf1-x42d.google.com with SMTP id q12so3553853pff.9 for ; Tue, 17 Sep 2019 22:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=U0UTNfP5Mev3gkw/3G/YxtdbpcqfPH4G9uwh2bhmydc=; b=NWVichQhmHctLNCNPLnupfrov9MaWZ/k7i7lvOf6A4M3QxkdOWsDyJSPipR74dNOEc 05+v2n9Yl9yiCbYECs8MLUV5UDTv9HUJfBfDrhb9x/cO7HASMeXRlXFAGMYHIMCwSwHy 9dcRX4Qbi+INrE55QXOSt27z6xOcTFfpsnF4OlxLPTn4RP3n0e+2PUK2Fm+Skvcs/QAY O9sNchkE7Bxl/TeBY5V1QxHNh77aYQXc5uOdG/XBaGkm8hapbYvwLHje4r1L7zK1x4pq fNDP3UIdmUthil5+k2bfwx1kSVJLpt+DzhJ+VF/xVJHSFiZWoKcgOJAMSDKi9f//fmRZ +qvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=U0UTNfP5Mev3gkw/3G/YxtdbpcqfPH4G9uwh2bhmydc=; b=o+nl9iJWJmaJNvRjllbY47XqjIFjO9QIb9tk1gNCbJnJmrpyPco3QhhYiBaqoP4GtP kdsFvn0q0H4Aembdl/udS5LxAFtWdusa6jZEcbscdTJLgEfAI8nViNDf2RnOfktOhyU6 CvbjbCMs7nR3+R8VHN6AG4Iw21i83FfHxyYmOLbe+E5Oizv57zjqoed+cVQddL6iYwF8 c+jsFG2BJyM7bzyprrLMQELlLZvIJTCxjuY3Dw7YvnAXOWUaOJLtxjw0WS24SSlVnoUc b4lEyZRyJaInN7bKtK4+3QgD5Ek4yv0SlM6m4HySaOmyJ4oAgAAhbRoYh/CC8M+//xES 6sag== X-Gm-Message-State: APjAAAUp9CRglgjoiUo15Lsx7bSR1qXQqm28Xnm3/J/geY54qrmnkKez xUO/BJr8b8rRiqYFK8wSFzg= X-Google-Smtp-Source: APXvYqw8tibJE6tjR5Tf745I4CYHzvQv5ua0tAit1GBWZ39M3QlbecbBzV1zJKmAXPVXnFouetOPsg== X-Received: by 2002:a65:4781:: with SMTP id e1mr2272263pgs.386.1568783470984; Tue, 17 Sep 2019 22:11:10 -0700 (PDT) Received: from [100.107.254.7] ([223.186.158.250]) by smtp.gmail.com with ESMTPSA id j1sm933527pjs.28.2019.09.17.22.11.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 22:11:10 -0700 (PDT) Mime-Version: 1.0 (1.0) Subject: Re: BBR patches? From: vm finance X-Mailer: iPhone Mail (16G102) In-Reply-To: <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> Date: Wed, 18 Sep 2019 10:41:07 +0530 Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net Message-Id: References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> To: Randall Stewart X-Rspamd-Queue-Id: 46Y7Nw3rWRz3LFw X-Spamd-Bar: ++++++++++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=NWVichQh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::42d as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [10.97 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GREYLIST(0.00)[pass,meta]; R_SPF_ALLOW(0.00)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[gmail.com:s=20161025]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; NEURAL_SPAM_MEDIUM(0.98)[0.983,0]; BAD_REP_POLICIES(0.10)[]; RECEIVED_SPAMHAUS_PBL(0.00)[250.158.186.223.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(0.98)[0.985,0]; RCVD_IN_DNSWL_NONE(0.00)[d.2.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; URIBL_BLACK(7.50)[osboxes.org.multi.uribl.com]; IP_SCORE_FREEMAIL(0.00)[]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(0.00)[ip: (-9.02), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)] X-Spam: Yes Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 05:11:13 -0000 Actually I am on head already as mentioned previously. Pulled it using yeste= rday: >> svn co svn://svn.freebsd.org/base/head /use/src If you could pls let me know the new patch, I can try that. Thanks=20 Sent from my iPhone > On 18-Sep-2019, at 8:56 AM, Randall Stewart wrote: >=20 > There have been several patches pre-this one that provide > the infrastructure to support BBR. >=20 > Release 12.0 will *not* have these patches and will *not* compile it. >=20 > I have no intention at this point in doing a MFC of this work.. so if you w= ant > to run BBR you need to run Head >=20 > R >=20 >> On Sep 17, 2019, at 7:26 PM, vm finance wrote: >>=20 >> Hi Randall, >>=20 >> Could you please provide a pointer to the latest patch. I had applied the= one you published Sep-10. >>=20 >> Following is what I have done: >> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org >> 2. Got VM up under VMPlayer on x86 laptop >> 3. Checked out latest codebase from freebsd repo: >> svn co svn://svn.freebsd.org/base/head /usr/src* >> cd /usr/src; >> make buildworld buildkernel =20 >> [this is where make fails when patch is applied] >>=20 >> I could try to build with your latest patch - please send me a pointer. >>=20 >> Thanks for your help! >>=20 >>=20 >> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart wrote: >> Looking at your make file log I can=E2=80=99t really tell what you are do= ing. >>=20 >> Its not the BBR or Rack code that is blowing up=E2=80=A6=20 >>=20 >> Are you cross compiling? >>=20 >> I have done the old fashioned kernel make >>=20 >> i.e.=20 >>=20 >> cd src/sys/amd64/config >> config headvm >> cd ../compile/headvm >>=20 >> make cleandepend ; make depend; make -j3 >>=20 >> I have done >>=20 >> cd src >> make buildkernel KERNCONF=3Dheadvm >>=20 >> And even >>=20 >> make buildkernel KERNCONF=3DGENERIC >>=20 >> to make sure that the build works without bbr. >>=20 >> I attach my headvm config.. >>=20 >> What exactly are you building and how? kernel config too please? >>=20 >> R >>=20 >>=20 >>=20 >>=20 >>> On Sep 17, 2019, at 1:11 PM, Randall Stewart wrote: >>>=20 >>> looking >>>=20 >>> I was at 352408.. let me update and try it >>>=20 >>> R >>>=20 >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart wrote: >>>>=20 >>>> Hmm >>>>=20 >>>> Did you get the patch I updated too this am? >>>>=20 >>>> I have built it both with and without the bbr stack and had no issue.. t= here was >>>> an issue with KTLS before the update though. >>>>=20 >>>> I don=E2=80=99t recognize what you have below there though=E2=80=A6 >>>>=20 >>>> R >>>>=20 >>>>> On Sep 17, 2019, at 11:47 AM, vm finance wrote= : >>>>>=20 >>>>> Got it - thank you! >>>>>=20 >>>>> btw, I tried to build the patch but its giving an error. Following is S= VN info + make error mesg. >>>>>=20 >>>>> Please let me know what am I missing here? >>>>>=20 >>>>> Thanks! >>>>>=20 >>>>> #svnlite revision >>>>> Path: . >>>>> Working Copy Root Path: /usr/src >>>>> URL: svn://svn.freebsd.org/base/head >>>>> Relative URL: ^/head >>>>> Repository Root: svn://svn.freebsd.org/base >>>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>>>> Revision: 352436 >>>>> Node Kind: directory >>>>> Schedule: normal >>>>> Last Changed Author: jah >>>>> Last Changed Rev: 352434 >>>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>>>>=20 >>>>> root@osboxes:/usr/src # >>>>>=20 >>>>> -------------------------------------------- snip --------------------= -------- >>>>>=20 >>>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo dev_net.l= lo bcache.llo interp_simple.llo zfs_cmd.llo >>>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>>>> =3D=3D=3D> sys (cleandir) >>>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o sack_filter= .o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h opt_k= ern_tls.h >>>>> rm: x86: is a directory >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make[3]: stopped in /usr/src/sys >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make[2]: stopped in /usr/src >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make[1]: stopped in /usr/src >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make: stopped in /usr/src >>>>>=20 >>>>>=20 >>>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance wro= te: >>>>> Got it - thank you! >>>>>=20 >>>>> btw, I tried to build the patch but its giving an error. Following is S= VN info + make error mesg. >>>>> I have also attached the entire build log...snippet is below >>>>>=20 >>>>> Please let me know what am I missing here? >>>>>=20 >>>>> Thanks! >>>>>=20 >>>>> #svnlite revision >>>>> Path: . >>>>> Working Copy Root Path: /usr/src >>>>> URL: svn://svn.freebsd.org/base/head >>>>> Relative URL: ^/head >>>>> Repository Root: svn://svn.freebsd.org/base >>>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>>>> Revision: 352436 >>>>> Node Kind: directory >>>>> Schedule: normal >>>>> Last Changed Author: jah >>>>> Last Changed Rev: 352434 >>>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>>>>=20 >>>>> root@osboxes:/usr/src # >>>>>=20 >>>>> -------------------------------------------- snip --------------------= -------- >>>>>=20 >>>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo dev_net.l= lo bcache.llo interp_simple.llo zfs_cmd.llo >>>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>>>> =3D=3D=3D> sys (cleandir) >>>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o sack_filter= .o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h opt_k= ern_tls.h >>>>> rm: x86: is a directory >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make[3]: stopped in /usr/src/sys >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make[2]: stopped in /usr/src >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make[1]: stopped in /usr/src >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make: stopped in /usr/src >>>>>=20 >>>>>=20 >>>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart wrot= e: >>>>> Pacing is provided by tcp_hpts.c. The current linux patches do not hav= e >>>>> to have fq.. they built an alternate means of doing pacing into bbr. >>>>>=20 >>>>> In either case our testing has shown that our pacing is more accurate t= han >>>>> either fq or the internal pacer :) >>>>>=20 >>>>> R >>>>>=20 >>>>>> On Sep 17, 2019, at 11:05 AM, vm finance wrot= e: >>>>>>=20 >>>>>> Thanks Randall. >>>>>> I was able to apply the patch - now rebuilding the kernel. Would upda= te on how it goes. >>>>>>=20 >>>>>> BTW, is there any description on how lack of tc_fq under FreeBSD is c= ompensated here? >>>>>> The original BBR patches on Linux show that as a must-have? Is that f= unctionality implemented via tcp_ratelimit.[ch]? >>>>>>=20 >>>>>> Any pointers to existing presentations/discussions highly appreciated= ? >>>>>>=20 >>>>>> Thanks a lot. >>>>>>=20 >>>>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart wro= te: >>>>>> You should be able to compile it against the current head. I re-doing= that now (had an >>>>>> issue with my machine and had to roll it back to a backup). >>>>>>=20 >>>>>> When I put the patch up on Sept 10th it complied with and without BBR= on whatever >>>>>> was that rev.. >>>>>>=20 >>>>>> Looking in the commit logs that would have been around 352191 >>>>>>=20 >>>>>> Hope that helps >>>>>>=20 >>>>>> R >>>>>>=20 >>>>>>> On Sep 17, 2019, at 3:32 AM, vm finance wrot= e: >>>>>>>=20 >>>>>>> Hi Randall, >>>>>>>=20 >>>>>>> Thanks for releasing BBR patch: >>>>>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq=20 >>>>>>>=20 >>>>>>> Could you please let me know what SVN/GIT label tag this is based on= ? I would like to patch and experiment with it. I couldn't find this info in= the released patch. >>>>>>>=20 >>>>>>> Thanks a lot!=20 >>>>>>>=20 >>>>>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone wrot= e: >>>>>>> rrs@ has just posted the BBR patch to phabricator: >>>>>>>=20 >>>>>>> https://reviews.freebsd.org/D21582 >>>>>>=20 >>>>>> ------ >>>>>> Randall Stewart >>>>>> rrs@netflix.com >>>>>>=20 >>>>>>=20 >>>>>>=20 >>>>>=20 >>>>> ------ >>>>> Randall Stewart >>>>> rrs@netflix.com >>>>>=20 >>>>>=20 >>>>>=20 >>>>=20 >>>> ------ >>>> Randall Stewart >>>> rrs@netflix.com >>>>=20 >>>>=20 >>>>=20 >>>=20 >>> ------ >>> Randall Stewart >>> rrs@netflix.com >>>=20 >>>=20 >>>=20 >>=20 >> ------ >> Randall Stewart >> rrs@netflix.com >>=20 >>=20 >>=20 >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20