Date: Wed, 7 May 1997 01:20:01 -0700 (PDT) From: "Serge V.Vakulenko" <vak@crox.net.kiae.su> To: freebsd-bugs Subject: Re: i386/3523: [patch] sio: automatic detection of 16550/16750 controllers Message-ID: <199705070820.BAA10257@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR i386/3523; it has been noted by GNATS.
From: "Serge V.Vakulenko" <vak@crox.net.kiae.su>
To: Poul-Henning Kamp <phk@dk.tfs.com>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: i386/3523: [patch] sio: automatic detection of 16550/16750 controllers
Date: Wed, 7 May 1997 12:13:14 +0400 (MSD)
On Tue, 6 May 1997, Poul-Henning Kamp wrote:
>
> I applied this to my -current system, and it correctly identifies
> my 650 chips, but I don't like that it also says 550 on those lines:
>
> sio0 at 0x3f8-0x3ff irq 4 on isa
> sio0: type 16550A
> sio1 at 0x2f8-0x2ff irq 3 on isa
> sio1: type 16550A
> sio2 at 0x2a0-0x2a7 irq 10 flags 0x285 on isa
> sio2: type 16650 16550A (multiport master)
> sio3 at 0x2a8-0x2af flags 0x285 on isa
> sio3: type 16650 16550A (multiport)
> sio4 at 0x2b0-0x2b7 flags 0x285 on isa
> sio4: type 16650 16550A (multiport)
> sio5 at 0x2b8-0x2bf flags 0x285 on isa
> sio5: type 16550A (multiport)
>
> (sio5 is correct, I swapped that chip with an 550A some time ago.)
Sorry, just a mistype...
See the patch below.
> I guess we should report the fifo depth too ?
I am not sure this makes sense.
Serge
--- sio.c.b Tue May 6 23:28:37 1997
+++ sio.c Wed May 7 12:09:09 1997
@@ -893,9 +893,10 @@
} else if (n > 24) {
com->tx_fifo_size = 32;
printf(" 16650");
- } else
+ } else {
com->tx_fifo_size = 16;
printf(" 16550A");
+ }
#ifdef COM_ESP
for (espp = likely_esp_ports; *espp != 0; espp++)
if (espattach(isdp, com, *espp)) {
___
Serge Vakulenko <vak@cronyx.ru>
Cronyx Engineering Ltd., Moscow Digital communication hardware development,
phone/fax: +7 (095) 196-40-53 Internet services, FreeBSD support
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199705070820.BAA10257>