From owner-svn-src-all@freebsd.org Sat Jul 11 14:33:11 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5914B998AF6; Sat, 11 Jul 2015 14:33:11 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: from mail-yk0-x232.google.com (mail-yk0-x232.google.com [IPv6:2607:f8b0:4002:c07::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 190591695; Sat, 11 Jul 2015 14:33:11 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: by ykax123 with SMTP id x123so36498245yka.1; Sat, 11 Jul 2015 07:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=fZ9EC+gn28HqpEq1RldxVKhaLmUNfqgSA5AKjFmE1KA=; b=YV79arizanU+ZSc9cY29tXDBjarG5vgBMtGGaHnGxLxX64HUPg7k4zI/prds65Ce51 U5HEkK8Maem+HHeQwmE2Wv6c4aY2yqqi3iQW7dcrIUaSoHCybXSDl2XXI0sgZJ0zRbUV 75qZv/wQLhOw9Nkb0HGguj0SruXCR6vsvsiDetwrAFQNpDScyf1AtYjWTjprFtv7g9EL kJvI8lhD8SwqKFDDFjO9MOOoG6bE/OEsKcwdlG9G9QSE9kU/txAXJb+wuC2+e0dIGQnL Ay9lEFILAL+8YfB+8aigWQasLG02wx0jyGkOi/OAtyHt+FtNCstVtW0W5lBrVyAaPMeV +nRg== MIME-Version: 1.0 X-Received: by 10.170.36.197 with SMTP id 188mr14932539yke.10.1436625190136; Sat, 11 Jul 2015 07:33:10 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.37.11.70 with HTTP; Sat, 11 Jul 2015 07:33:10 -0700 (PDT) In-Reply-To: <20150711142920.GE8523@funkthat.com> References: <201507110312.t6B3CZBv081280@repo.freebsd.org> <20150711080439.GD8523@funkthat.com> <20150711142920.GE8523@funkthat.com> Date: Sat, 11 Jul 2015 10:33:10 -0400 X-Google-Sender-Auth: T8amKnlMxdli-rKi0BwY3LKe8p4 Message-ID: Subject: Re: svn commit: r285366 - in head: lib/libmd sys/crypto/sha2 From: Craig Rodrigues To: John-Mark Gurney Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jul 2015 14:33:11 -0000 On Sat, Jul 11, 2015 at 10:29 AM, John-Mark Gurney wrote: > Craig Rodrigues wrote this message on Sat, Jul 11, 2015 at 10:16 -0400: > > > So it looks like _libmd_SHA256_File is not defined in the legacy > > library used during the bootstrap. > > The closest I can see is that sha256hl.c (from mdXhl.c) is including > "sha256.h" with double quotes, and getting the wrong header file.. > > Yes, I think you are right. If I go to src/lib/libmd, and type: make -V CFLAGS I see: -O2 -pipe -I/builds/FreeBSD_HEAD/lib/libmd -DWEAK_REFS -std=gnu99 -Qunused-arguments -fstack-protector -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parentheses After your change, there is no sha256.h file in the src/lib/libmd directory, so the bootstrap stage is picking up sha256.h from /usr/include , which causes problems. -- Craig