From owner-freebsd-ipfw@FreeBSD.ORG  Tue May 10 17:00:59 2005
Return-Path: <owner-freebsd-ipfw@FreeBSD.ORG>
Delivered-To: freebsd-ipfw@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A59CC16A4CE
	for <freebsd-ipfw@freebsd.org>; Tue, 10 May 2005 17:00:59 +0000 (GMT)
Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.206])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2EB1D43D8C
	for <freebsd-ipfw@freebsd.org>; Tue, 10 May 2005 17:00:59 +0000 (GMT)
	(envelope-from jsimola@gmail.com)
Received: by wproxy.gmail.com with SMTP id 69so1967332wri
        for <freebsd-ipfw@freebsd.org>; Tue, 10 May 2005 10:00:58 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
	s=beta; d=gmail.com;
	h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=Q0zVmm2SQSDlnjtIynBmPEPsRSkhxhvMenhg1wEVo//h76J/jdWjwBGL80Iurj4IJR2kqR3Z82Ddps6Ny5VcQaFTebNp5rxcAHJ3Tu5dRJDuEwdr1/KR9NZEGLsQXJd1nzDf5SjSAAEy/8UTI/FxQWs47IF+f6c7LEXfmT/dQN4=
Received: by 10.54.3.6 with SMTP id 6mr626121wrc;
        Tue, 10 May 2005 10:00:58 -0700 (PDT)
Received: by 10.54.39.6 with HTTP; Tue, 10 May 2005 10:00:58 -0700 (PDT)
Message-ID: <8eea04080505101000d1180ce@mail.gmail.com>
Date: Tue, 10 May 2005 10:00:58 -0700
From: Jon Simola <jsimola@gmail.com>
To: freebsd-ipfw@freebsd.org
In-Reply-To: <200505101350.j4ADonjj053834@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <200505101350.j4ADonjj053834@freefall.freebsd.org>
Subject: Re: kern/73276: ipfw2 vulnerability (parser error)
X-BeenThere: freebsd-ipfw@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: jon@abccomm.com
List-Id: IPFW Technical Discussions <freebsd-ipfw.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ipfw>
List-Post: <mailto:freebsd-ipfw@freebsd.org>
List-Help: <mailto:freebsd-ipfw-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 May 2005 17:00:59 -0000

On 5/10/05, Tilman Linneweh <arved@freebsd.org> wrote:
> Synopsis: ipfw2 vulnerability (parser error)
>=20
> Responsible-Changed-From-To: freebsd-bugs->freebsd-ipfw
> Responsible-Changed-By: arved
> Responsible-Changed-When: Tue May 10 13:50:30 GMT 2005
> Responsible-Changed-Why:
> Over to ipfw mailinglist
>=20
> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D73276

More accurately, anything after the closing '}' is ignored by the
parser. I'm pretty sure this fixes that.

--- ipfw2.c.orig        Tue May 10 08:45:12 2005
+++ ipfw2.c     Tue May 10 09:53:08 2005
@@ -2088,8 +2088,11 @@
                        i =3D -1;
                        if (*s =3D=3D '-')
                            i =3D a;
-                       else if (*s =3D=3D '}')
+                       else if (*s =3D=3D '}') {
+                           if (strlen(s) > 1)
+                               errx(EX_DATAERR, "trailing garbage after '}=
'");
                            break;
+                       }
                        av =3D s+1;
                }
                return;



--=20
Jon Simola
Systems Administrator
ABC Communications