Date: Fri, 27 Dec 2019 01:13:23 +0000 From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 242746] ifconfig: Deleting (or re-setting) an IP address holds (leaks?) memory Message-ID: <bug-242746-7501-sRuq1B2M8E@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-242746-7501@https.bugs.freebsd.org/bugzilla/> References: <bug-242746-7501@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242746 --- Comment #6 from commit-hook@freebsd.org --- A commit references this bug: Author: markj Date: Fri Dec 27 01:12:54 UTC 2019 New revision: 356107 URL: https://svnweb.freebsd.org/changeset/base/356107 Log: Plug some ifaddr refcount leaks. - Only take an ifaddr ref in in rt_exportinfo() if the caller explicitly requests it. Take care to release it in this case. - Don't unconditionally take a ref in rtrequest1_fib(). rt_getifa_fib() will acquire a reference, in which case we would previously acquire two references. - Stop taking a reference in rtinit1() before calling rtrequest1_fib(). rtrequest1_fib() will acquire a reference for the RTM_ADD case. PR: 242746 Reviewed by: melifaro (previous version) Tested by: ghuckriede@blackberry.com MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D22912 Changes: head/sys/net/route.c --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-242746-7501-sRuq1B2M8E>