From owner-svn-ports-all@FreeBSD.ORG  Sat Jul 27 17:20:56 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id E4A8E58C; Sat, 27 Jul 2013 17:20:56 +0000 (UTC)
Date: Sat, 27 Jul 2013 17:20:56 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Andrej Zverev <az@freebsd.org>
Subject: Re: svn commit: r323795 - in head: audio/mp32ogg audio/p5-Shout
 databases/p5-DBD-InterBase databases/p5-DBIx-Class-TimeStamp
 databases/p5-DBIx-MySQLSequence devel/cvslines devel/cvsplot devel/cvsstat
 d...
Message-ID: <20130727172056.GA95369@FreeBSD.org>
References: <201307271606.r6RG6PoL038173@svn.freebsd.org>
 <20130727162504.GA78281@FreeBSD.org>
 <CAD5bB+jewTn+B301gtkr1BVmSQsU+D7wy2We=bcd5ZsX=2y-cw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAD5bB+jewTn+B301gtkr1BVmSQsU+D7wy2We=bcd5ZsX=2y-cw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Jul 2013 17:20:57 -0000

On Sat, Jul 27, 2013 at 09:10:47PM +0400, Andrej Zverev wrote:
> On Sat, Jul 27, 2013 at 8:25 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > On Sat, Jul 27, 2013 at 04:06:25PM +0000, Andrej Zverev wrote:
> >> New Revision: 323795
> >> URL: http://svnweb.freebsd.org/changeset/ports/323795
> >>
> >> @@ -32,7 +29,7 @@ NO_BUILD=   yes
> >>  PLIST_FILES= bin/mp32ogg
> >>
> >>  post-patch:
> >> -     @${PERL} -pi -e "s,%%LOCALBASE%%,${LOCALBASE},g" ${WRKSRC}/mp32ogg
> >> +     @${REINPLACE_CMD} -i '' -e 's|%%LOCALBASE%%|${LOCALBASE}|' [...]
> >
> > Andrej, can you clarify why explicit -i '' is needed here and quite a few
> > other ports in the commit?  Is it because of otherwise .bak files will be
> > installed?  Just looks weird to see these args all over the place...
> 
> Yes, thats a reason. I don't see (personally) why REPLACE ARGS default
> with -i.bak, but overriding port Makefile everytime really annoying :(

Understood, thanks for clarification.

./danfe

P.S.  Personally I like having those .bak files around, because it makes
debugging (via diff'ing) so much easier.  Not related to the commit, but
just in case someone(tm) would have an idea to suppress them by default.
Please don't.  Thank you.