From owner-p4-projects@FreeBSD.ORG  Mon Mar  5 22:31:26 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E7EE116A40F; Mon,  5 Mar 2007 22:31:25 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C57A616A407;
	Mon,  5 Mar 2007 22:31:25 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.freebsd.org (Postfix) with ESMTP id 6CD5113C467;
	Mon,  5 Mar 2007 22:31:25 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l25MVLIF005346;
	Mon, 5 Mar 2007 17:31:21 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Paolo Pisati <piso@freebsd.org>
Date: Mon, 5 Mar 2007 17:26:26 -0500
User-Agent: KMail/1.9.1
References: <200703052146.l25LkM0V057457@repoman.freebsd.org>
In-Reply-To: <200703052146.l25LkM0V057457@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200703051726.26875.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Mon, 05 Mar 2007 17:31:21 -0500 (EST)
X-Virus-Scanned: ClamAV 0.88.3/2736/Mon Mar 5 13:55:43 2007 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 115367 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Mar 2007 22:31:26 -0000

On Monday 05 March 2007 16:46, Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=115367
> 
> Change 115367 by piso@piso_newluxor on 2007/03/05 21:45:54
> 
> 	o Wrap at 80 ata_pci_setup_intr().
> 	o Style(9) a bit the indentation.

You should really preserve the 4-space indent since that's what the rest of 
sys/dev/ata/* uses, and consistency is preserved over a mixed bag.

> Affected files ...
> 
> .. //depot/projects/soc2006/intr_filter/dev/ata/ata-pci.c#6 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2006/intr_filter/dev/ata/ata-pci.c#6 (text+ko) ====
> 
> @@ -339,12 +339,12 @@
>  
>  int
>  ata_pci_setup_intr(device_t dev, device_t child, struct resource *irq, 
> -		   int flags, driver_filter_t *filter, driver_intr_t *function, 
> -		   void *argument, void **cookiep)
> +    int flags, driver_filter_t *filter, driver_intr_t *function, 
> +    void *argument, void **cookiep)
>  {
>      if (ata_legacy(dev)) {
> -	return BUS_SETUP_INTR(device_get_parent(dev), child, irq,
> -			      flags, filter, function, argument, cookiep);
> +	    return BUS_SETUP_INTR(device_get_parent(dev), child, irq, 
> +	               flags, filter, function, argument, cookiep);
>      }
>      else {
>  	struct ata_pci_controller *controller = device_get_softc(dev);
> 

-- 
John Baldwin