From owner-svn-src-head@FreeBSD.ORG Mon May 4 15:45:09 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AC659832; Mon, 4 May 2015 15:45:09 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 875FC1F2A; Mon, 4 May 2015 15:45:09 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 89561B9B0; Mon, 4 May 2015 11:45:08 -0400 (EDT) From: John Baldwin To: Gleb Smirnoff Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282280 - in head/sys/dev: e1000 ixgbe ixl Date: Mon, 04 May 2015 09:58:49 -0400 Message-ID: <26088556.xbkUe5VAyp@ralph.baldwin.cx> User-Agent: KMail/4.14.2 (FreeBSD/10.1-STABLE; KDE/4.14.2; amd64; ; ) In-Reply-To: <20150502191000.GE546@FreeBSD.org> References: <201504301823.t3UINd74073186@svn.freebsd.org> <2197979.EUYqekgM4M@ralph.baldwin.cx> <20150502191000.GE546@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 04 May 2015 11:45:08 -0400 (EDT) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2015 15:45:09 -0000 On Saturday, May 02, 2015 10:10:00 PM Gleb Smirnoff wrote: > On Fri, May 01, 2015 at 10:47:43AM -0400, John Baldwin wrote: > J> > J> > While you are here, let me remind you about this plan: > J> > J> > > J> > J> > https://lists.freebsd.org/pipermail/svn-src-head/2014-October/063575.html > J> > J> > > J> > J> > We can prototype the API to userland now, write down a utility that uses > J> > J> > it, or add the functionality to an existing utility. And start with Intel > J> > J> > drivers, that seem to be most interested in extra stats. > J> > J> > J> > J> So the importaing thing here is that if_get_counter() is still doing > J> > J> per-ifnet stats. The stat you underlined above is per-queue instead. > J> > J> We well need more explicitly knowledge of queues outside of drivers > J> > J> and in the stack itself to support a generic framework for per-queue > J> > J> stats. > J> > > J> > This depends on how generic we want the API to be. Of course, we can add > J> > an extra argument to if_get_counter(). > J> > > J> > However, if we don't expect the number of queues to exceed a reasonable > J> > number of 255 :), we can fit the functionality into existing API. > J> > We can keep the queue number in the highest 8 bits of the ift_counter > J> > parameter. > J> > > J> > #define IFCOUNTER_MASK 0x00ffffff > J> > #define IFCOUNTER_QUEUE(c) ((c) >> 24) > J> > J> I'd prefer that expose queues more directly and figure out how to handle > J> per-queue stats then (e.g. do we have some sort of driver-independent > J> structure that each ifnet has 1 or more of that maps to a queue and has > J> driver provided methods, etc. If so you could have a driver method for > J> queue stats). Note that I did use if_get_counter to report the > J> per-interface stats instead of adding a new sysctl. > > What do you prefer: an extra argument to the if_get_counter() or a extra > ifop? As I said, I'd prefer we expose queues to the stack more directly complete with per-queue ops (e.g. I'd like a per-queue if_transmit thing, though probably more like the old if_start). -- John Baldwin