From owner-freebsd-current@freebsd.org Tue Nov 10 02:01:52 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9EF96A2A365 for ; Tue, 10 Nov 2015 02:01:52 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-yk0-x235.google.com (mail-yk0-x235.google.com [IPv6:2607:f8b0:4002:c07::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 66BDC1FCF; Tue, 10 Nov 2015 02:01:52 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by ykdv3 with SMTP id v3so205645702ykd.0; Mon, 09 Nov 2015 18:01:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=sG5ynhK81jlPPUqKOjKcLNByTbGjCjtVJvTEgqNpMq8=; b=lM+gNKdh8UfUv2w4vcXbyicHq5IFUURyLGI0CiVYbbCg9PdcFYczQ3vz0JSv7irNZs //DKTc+3J3vzvnmWRLcvFAk/2Tdju7zt+5gjwt0Ey4zN9PZF73RWKwJRnKZDA7VtydrG x2QTJfJULYOyX7EysqsBw/FEpkURtIh3k83O82mVwrtroOmAm96vyJu55qc1xhxUsxvG 24E4gbWmgDB+xWZR2bCTzgyfLB7xh+F1WYEOxwLA3DG21DISwJpqVw7Hj2r1iqvwHirg o456Uw04gOooiuLj4kaEqw67knQOjMDJI7UwymqTBmz1DZgSdnfwGQtFYxMl/ERaqSeu qajA== X-Received: by 10.13.204.149 with SMTP id o143mr1013935ywd.46.1447120911552; Mon, 09 Nov 2015 18:01:51 -0800 (PST) Received: from [21.196.67.138] ([172.56.14.167]) by smtp.gmail.com with ESMTPSA id m130sm1311946ywb.48.2015.11.09.18.01.50 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 09 Nov 2015 18:01:51 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: Failing buildword due to execution permission (with fix) From: Garrett Cooper X-Mailer: iPhone Mail (13B143) In-Reply-To: <564147FF.2050107@FreeBSD.org> Date: Mon, 9 Nov 2015 18:01:49 -0800 Cc: =?utf-8?Q?Jos=C3=A9_P=C3=A9rez?= , freebsd-current@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <45AD4F5D-DABD-47ED-99FA-A40FFFF3CC7E@gmail.com> References: <233C431B-1675-4A55-A46E-B1B858056A09@gmail.com> <564136A0.4080406@FreeBSD.org> <5655EBD2-5EC5-425E-82B9-F7FF30312F02@gmail.com> <564147FF.2050107@FreeBSD.org> To: Bryan Drewery X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 02:01:52 -0000 > On Nov 9, 2015, at 17:27, Bryan Drewery wrote: >=20 >> On 11/9/2015 5:17 PM, Garrett Cooper wrote: >>=20 >>> On Nov 9, 2015, at 16:13, Bryan Drewery wrote: >>=20 >>=20 >> ... >>=20 >>> If this is a shell file then it is best to invoke it with 'sh' rather >>> than a chmod/#!. The src checkout should be noexec-safe. >>=20 >> Right. I think it'd be a good idea for me to hunt down other issues thoug= h in the build by setting -o noexec. >>=20 >>=20 >> The only thing that concerns me with doing that is that it could result i= n weirdness, e.g. The osreldate.h generation script in include/ . >=20 > It prepends 'sh'. >=20 > include/Makefile:MK_OSRELDATE_SH=3D ${.CURDIR}/mk-osreldate.sh > include/Makefile: sh ${MK_OSRELDATE_SH} Yeah... I forgot. I wrote up that patch at iX, and it was iterated over a bit. I was just reme= mbering what happens when you use ${SHELL} (hint: no bueno if your build is k= icked off with a csh/non-POSIX sh..). I'll do that soon-ish. Thanks! -NGie=