From owner-freebsd-current Mon Oct 28 13:37:43 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4801137B401 for ; Mon, 28 Oct 2002 13:37:42 -0800 (PST) Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE90A43E3B for ; Mon, 28 Oct 2002 13:37:41 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 27200 invoked from network); 28 Oct 2002 21:37:49 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail12.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 28 Oct 2002 21:37:49 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id g9SLbdn5088665; Mon, 28 Oct 2002 16:37:40 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <1035840812.328.3.camel@gyros.marcuscom.com> Date: Mon, 28 Oct 2002 16:37:39 -0500 (EST) From: John Baldwin To: Joe Marcus Clarke Subject: Re: libgtop port and v_tag changes Cc: current@FreeBSD.org, Nate Lawson , Terry Lambert Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 28-Oct-2002 Joe Marcus Clarke wrote: > On Mon, 2002-10-28 at 16:27, John Baldwin wrote: >> >> On 28-Oct-2002 Terry Lambert wrote: >> > John Baldwin wrote: >> >> I mean, do you know what libgtop is used for? It's used to draw >> >> little applets that display load averages and other silly system >> >> monitor stuff in small spaces in GUI's. It seems to work quite >> >> happily w/o any inode numbers or dev_t's for non-UFS filesystems. >> >> I just don't see why some little graphical applet displaying a load >> >> average or disk usage or ethernet device usage needs the inode >> >> number and dev_t of vnode's in the kernel. I mean, geez. >> > >> > To build little applets that activate a flashing red light when >> > certain files are written? >> >> Why do you need the inode number to do that. Just kqueue on the >> file itself using a regular fd, and in that case you can stat(2) >> the file if you really need the i-node number. You don't need >> to use libkvm to actually go read the kernel to find this info! > > You're probably right. But without waiting to re-architect libgtop, I > think the immediate problem needs to be fixed. Shall I just commit my > original patch that uses libkvm? Use v_cachedid and v_cachedfs for all VREG vnodes. Then you don't need to even go near v_tag. This is fewer kvm_read()'s. If stable has the v_cachedid then it should be using that instead of reading in UFS inodes as well. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message