From owner-freebsd-hackers@freebsd.org Fri Dec 1 07:45:53 2017 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C9D44DEE498 for ; Fri, 1 Dec 2017 07:45:53 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7DEE774D93 for ; Fri, 1 Dec 2017 07:45:53 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from [88.198.220.132] (helo=sslproxy03.your-server.de) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1eKfco-0002X8-Vg for freebsd-hackers@freebsd.org; Fri, 01 Dec 2017 08:20:42 +0100 Received: from [82.135.62.35] (helo=mail.embedded-brains.de) by sslproxy03.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eKfco-0006CP-HM for freebsd-hackers@freebsd.org; Fri, 01 Dec 2017 08:20:42 +0100 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 17C3C2A109A for ; Fri, 1 Dec 2017 08:20:38 +0100 (CET) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 3biA1w3aB50P for ; Fri, 1 Dec 2017 08:20:37 +0100 (CET) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id DB8E22A166C for ; Fri, 1 Dec 2017 08:20:37 +0100 (CET) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ygrt0KvTE3k4 for ; Fri, 1 Dec 2017 08:20:37 +0100 (CET) Received: from linux-diu0.suse (unknown [192.168.96.129]) by mail.embedded-brains.de (Postfix) with ESMTP id B9F082A109A for ; Fri, 1 Dec 2017 08:20:37 +0100 (CET) From: Sebastian Huber To: freebsd-hackers@freebsd.org Subject: [PATCH] Destroy seltd st_mtx and st_wait in seltdfini() Date: Fri, 1 Dec 2017 08:20:40 +0100 Message-Id: <20171201072040.19831-1-sebastian.huber@embedded-brains.de> X-Mailer: git-send-email 2.12.3 X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.99.2/24089/Fri Dec 1 02:11:32 2017) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 07:45:53 -0000 A correct destruction is important for WITNESS(4) and LOCK_PROFILING(9). --- sys/kern/sys_generic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/kern/sys_generic.c b/sys/kern/sys_generic.c index 546b183ee87..c5b410fe8bd 100644 --- a/sys/kern/sys_generic.c +++ b/sys/kern/sys_generic.c @@ -1884,6 +1884,8 @@ seltdfini(struct thread *td) if (stp->st_free2) uma_zfree(selfd_zone, stp->st_free2); td->td_sel = NULL; + cv_destroy(&stp->st_wait); + mtx_destroy(&stp->st_mtx); free(stp, M_SELECT); } -- 2.12.3