From owner-p4-projects@FreeBSD.ORG  Mon Mar  5 22:31:26 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 530FF16A506; Mon,  5 Mar 2007 22:31:26 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D5E3916A409;
	Mon,  5 Mar 2007 22:31:25 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.freebsd.org (Postfix) with ESMTP id 6CF0113C471;
	Mon,  5 Mar 2007 22:31:25 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l25MVLIG005346;
	Mon, 5 Mar 2007 17:31:23 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Paolo Pisati <piso@freebsd.org>
Date: Mon, 5 Mar 2007 17:26:54 -0500
User-Agent: KMail/1.9.1
References: <200703052204.l25M4lnF061780@repoman.freebsd.org>
In-Reply-To: <200703052204.l25M4lnF061780@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200703051726.54857.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Mon, 05 Mar 2007 17:31:23 -0500 (EST)
X-Virus-Scanned: ClamAV 0.88.3/2736/Mon Mar 5 13:55:43 2007 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 115371 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Mar 2007 22:31:26 -0000

On Monday 05 March 2007 17:04, Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=115371
> 
> Change 115371 by piso@piso_newluxor on 2007/03/05 22:04:19
> 
> 	Wrap at 80 ppbus_setup_intr().

You can remove the cast instead.  C doesn't require casts for void * pointers.

> Affected files ...
> 
> .. //depot/projects/soc2006/intr_filter/dev/ppbus/ppbconf.c#5 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2006/intr_filter/dev/ppbus/ppbconf.c#5 (text+ko) 
====
> 
> @@ -421,7 +421,8 @@
>  {
>  	int error;
>  	struct ppb_data *ppb = DEVTOSOFTC(bus);
> -	struct ppb_device *ppbdev = (struct ppb_device *)device_get_ivars(child);
> +	struct ppb_device *ppbdev = 
> +	    (struct ppb_device *)device_get_ivars(child);
>  
>  	/* a device driver must own the bus to register an interrupt */
>  	if (ppb->ppb_owner != child)
> 

-- 
John Baldwin