From owner-p4-projects@FreeBSD.ORG  Wed Jan 31 00:48:20 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id DC7D916A403; Wed, 31 Jan 2007 00:48:19 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7E59116A401
	for <perforce@freebsd.org>; Wed, 31 Jan 2007 00:48:19 +0000 (UTC)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 6EFEA13C48D
	for <perforce@freebsd.org>; Wed, 31 Jan 2007 00:48:19 +0000 (UTC)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l0V0mJtH009069
	for <perforce@freebsd.org>; Wed, 31 Jan 2007 00:48:19 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l0V0mIfc009066
	for perforce@freebsd.org; Wed, 31 Jan 2007 00:48:18 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Wed, 31 Jan 2007 00:48:18 GMT
Message-Id: <200701310048.l0V0mIfc009066@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 113740 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jan 2007 00:48:20 -0000

http://perforce.freebsd.org/chv.cgi?CH=113740

Change 113740 by rwatson@rwatson_peppercorn on 2007/01/31 00:47:31

	Don't document the order the pointers are returned in by getzbuf.

Affected files ...

.. //depot/projects/zcopybpf/src/sys/net/bpf_zerocopy.c#5 edit

Differences ...

==== //depot/projects/zcopybpf/src/sys/net/bpf_zerocopy.c#5 (text+ko) ====

@@ -421,7 +421,8 @@
  * copied versions of those originally submitted via the setzbuf ioctl--if
  * user space has remapped the buffers, then they may be inconsistent.  User
  * applications must be aware that these are in effect buffer names, not
- * pointers, if they play such games with their address space.
+ * pointers, if they play such games with their address space.  Pointers are
+ * returned in arbitrary order, which may vary by ioctl.
  */
 int
 bpf_zerocopy_ioctl_getzbuf(struct thread *td, struct bpf_d *d,
@@ -432,9 +433,6 @@
 	KASSERT(d->bd_bufmode == BPF_BUFMODE_ZBUF,
 	    ("bpf_zerocopy_ioctl_getzbuf: not in zbuf mode"));
 
-	/*
-	 * Sort so that the next buffer to read is the 'a' buffer.
-	 */
 	bzero(bz, sizeof(*bz));
 	BPFD_LOCK(d);
 	if (d->bd_hbuf != NULL) {