From owner-cvs-all Sun Nov 10 21:43:31 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D4A9437B407; Sun, 10 Nov 2002 21:43:29 -0800 (PST) Received: from mail.chesapeake.net (chesapeake.net [205.130.220.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5647143E3B; Sun, 10 Nov 2002 21:43:25 -0800 (PST) (envelope-from jroberson@chesapeake.net) Received: from localhost (jroberson@localhost) by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id gAB5gU806038; Mon, 11 Nov 2002 00:42:30 -0500 (EST) (envelope-from jroberson@chesapeake.net) Date: Mon, 11 Nov 2002 00:42:30 -0500 (EST) From: Jeff Roberson To: Matthew Jacob Cc: Jake Burkholder , "Alan L. Cox" , , , Subject: Re: cvs commit: src/sys/vm uma_dbg.c In-Reply-To: Message-ID: <20021111003812.C97372-100000@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 10 Nov 2002, Matthew Jacob wrote: > > > > I guess getting rid of the ZONE_LOCK in uma_dbg_getslab is also needed > :-) > > I think this is the right thing. The reason that I wasn't holding the lock before is because the code in uma_dbg_ doesn't actually move things on and off of the free list. It just marks them as in a bucket or not, so that frees to seperate per cpu caches can be caught. I was assuming that the spin lock would be enough to keep the caches coherent, but I forgot that we don't do atomic writes to 8bit ints on many platforms. Feel free to add the appropriate locks to uma_dbg. If you want to punt on it I can address this when I get back in town. Thanks, Jeff To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message