From owner-freebsd-current Mon Feb 18 22:46:45 2002 Delivered-To: freebsd-current@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by hub.freebsd.org (Postfix) with ESMTP id B88AC37B400 for ; Mon, 18 Feb 2002 22:46:42 -0800 (PST) Received: (from dillon@localhost) by apollo.backplane.com (8.11.6/8.9.1) id g1J6kgE58769; Mon, 18 Feb 2002 22:46:42 -0800 (PST) (envelope-from dillon) Date: Mon, 18 Feb 2002 22:46:42 -0800 (PST) From: Matthew Dillon Message-Id: <200202190646.g1J6kgE58769@apollo.backplane.com> To: Peter Wemm Cc: current@FreeBSD.ORG Subject: Re: Patch sets to date and timing tests with Giant out of userret. References: <20020219063312.66ACD3BAD@overcee.wemm.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :> - mtx_lock(&Giant); :> - td->td_retval[0] = p->p_ucred->cr_ruid; :> + s = mtx_lock_giant(kern_giant_ucred); :> + td->td_retval[0] = td->td_ucred->cr_ruid; :> #if defined(COMPAT_43) || defined(COMPAT_SUNOS) :> - td->td_retval[1] = p->p_ucred->cr_uid; :> + td->td_retval[1] = td->td_ucred->cr_uid; :> #endif :> - mtx_unlock(&Giant); :> + mtx_unlock_giant(s); :> return (0); : :What a waste.. John has already done all this stuff already (using :td_ucred instead of p_ucred) over the entire tree. : :Cheers, :-Peter He didn't instrument Giant, and if you actually believe that one massive commit is going to be more stable then the piecemeal safe-mode commits I am making then you are smoking something. Or are you expecting John to commit his patchset piecemeal as well and test inbetween? If that is so, then he just wasted a whole lot time managing all this junk in P4 because, frankly, it only took me a few minutes to instrument the easier system calls. I spend far more time testing. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message