From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jul 9 10:40:02 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 308D2106568D for ; Thu, 9 Jul 2009 10:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E5FFF8FC0A for ; Thu, 9 Jul 2009 10:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n69Ae1nh009541 for ; Thu, 9 Jul 2009 10:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n69Ae1Ld009540; Thu, 9 Jul 2009 10:40:01 GMT (envelope-from gnats) Resent-Date: Thu, 9 Jul 2009 10:40:01 GMT Resent-Message-Id: <200907091040.n69Ae1Ld009540@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Thomas Quinot Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8DEDB10656A6 for ; Thu, 9 Jul 2009 10:39:26 +0000 (UTC) (envelope-from thomas@cuivre.fr.eu.org) Received: from melamine.cuivre.fr.eu.org (unknown [IPv6:2001:470:1f15:1531:212:3fff:fe75:91a5]) by mx1.freebsd.org (Postfix) with ESMTP id 523CC8FC15 for ; Thu, 9 Jul 2009 10:39:26 +0000 (UTC) (envelope-from thomas@cuivre.fr.eu.org) Received: by melamine.cuivre.fr.eu.org (Postfix, from userid 1000) id 648945D3BC; Thu, 9 Jul 2009 12:39:25 +0200 (CEST) Message-Id: <20090709103925.648945D3BC@melamine.cuivre.fr.eu.org> Date: Thu, 9 Jul 2009 12:39:25 +0200 (CEST) From: Thomas Quinot To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/136611: security/swatch: leaves zombies behind X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Thomas Quinot List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2009 10:40:02 -0000 >Number: 136611 >Category: ports >Synopsis: security/swatch: leaves zombies behind >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jul 09 10:40:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Thomas Quinot >Release: FreeBSD 7.1-STABLE i386 >Organization: >Environment: System: FreeBSD melamine.cuivre.fr.eu.org 7.1-STABLE FreeBSD 7.1-STABLE #1: Mon Feb 16 22:23:36 CET 2009 root@melamine.cuivre.fr.eu.org:/space/build/obj/space/build/src/RELENG_7/sys/GENERIC i386 >Description: When a Swatch rule has an "exec" action, child processes are not correctly cleaned up. >How-To-Repeat: Define an "exec" action and watch for zombie processes >Fix: The following quick and dirty patches adds a missing (blocking) waitpid call, it's fine if the action executes in bounded time, if not it needs to be refined. --- Actions.pm.orig Tue May 2 23:17:42 2006 +++ Actions.pm Thu Jul 9 12:20:27 2009 @@ -96,7 +96,7 @@ EXECFORK: { if ($exec_pid = fork) { - waitpid(-1, WNOHANG); + waitpid($exec_pid, 0); return 0; } elsif (defined $exec_pid) { exec($command); >Release-Note: >Audit-Trail: >Unformatted: