From owner-freebsd-net@FreeBSD.ORG Sat May 13 23:03:28 2006 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5BEE116A405; Sat, 13 May 2006 23:03:28 +0000 (UTC) (envelope-from bms@spc.org) Received: from mindfull.spc.org (mindfull.spc.org [83.167.185.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id A29BF43D45; Sat, 13 May 2006 23:03:27 +0000 (GMT) (envelope-from bms@spc.org) Received: from arginine.spc.org ([83.167.185.2]) by mindfull.spc.org with esmtps (TLSv1:AES256-SHA:256) (Exim 4.52) id 1Ff38m-0000jo-RM; Sun, 14 May 2006 00:03:16 +0100 Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id 8B1C26564F; Sun, 14 May 2006 00:03:16 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 12469-01-2; Sun, 14 May 2006 00:03:15 +0100 (BST) Received: by arginine.spc.org (Postfix, from userid 1078) id 8C5406564E; Sun, 14 May 2006 00:03:15 +0100 (BST) Date: Sun, 14 May 2006 00:03:15 +0100 From: Bruce M Simpson To: Stephen Clark , Robert Watson , freebsd-net@freebsd.org, pavlin@icir.org, atanu@icir.org Message-ID: <20060513230315.GE79277@spc.org> Mail-Followup-To: Bruce M Simpson , Stephen Clark , Robert Watson , freebsd-net@freebsd.org, pavlin@icir.org, atanu@icir.org References: <20060509122801.GA65297@spc.org> <20060509131517.GB79277@spc.org> <20060512030152.X20138@fledge.watson.org> <4463FD1D.9010600@seclark.us> <20060512131227.GD79277@spc.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060512131227.GD79277@spc.org> User-Agent: Mutt/1.4.1i Organization: Incunabulum X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - mindfull.spc.org X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - spc.org X-Source: X-Source-Args: X-Source-Dir: Cc: Subject: [PATCH] Re: IP_MAX_MEMBERSHIPS story. X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 May 2006 23:03:28 -0000 Hello, On Fri, May 12, 2006 at 02:12:27PM +0100, Bruce M Simpson wrote: > Therefore, joining the same group 20 times on different interfaces > would exceed IP_MAX_MEMBERSHIPS. > Fixing this in any way would still break the ip_mroute_kmod ABI and > as such is a HEAD change. A patch for this issue, against FreeBSD 6.1-RELEASE, is now available at this location: http://people.freebsd.org/~bms/ipmaxgroups.diff The general logic of the patch should also be applicable to other 4.4BSD-derived operating systems; the patch will probably also apply to HEAD with little or no fuzz. I have performed some initial testing (using mtest driven via jot to join a set of ephemeral multicast groups) on a 2-cpu system and it looks good from here. I would greatly appreciate further testing, particularly in a production routing environment such as yours, if at all possible. When I receive more feedback I will be happy to commit the patch. Because of the nature of this patch, it will break the ABI with regards to the ip_mroute kernel module (IPv4 multicast routing), therefore the patch can only be committed to HEAD for the time being. Regards, BMS