From owner-cvs-all Mon Nov 20 14:26:15 2000 Delivered-To: cvs-all@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id 4F8B637B479; Mon, 20 Nov 2000 14:26:13 -0800 (PST) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by pike.osd.bsdi.com (8.11.0/8.9.3) with ESMTP id eAKMQ6H87668; Mon, 20 Nov 2000 14:26:06 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20001119124403.M18037@fw.wintelcom.net> Date: Mon, 20 Nov 2000 14:26:38 -0800 (PST) From: John Baldwin To: Alfred Perlstein Subject: Re: cvs commit: src/sys/alpha/alpha clock.c db_interface.c inter Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Doug Rabson Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 19-Nov-00 Alfred Perlstein wrote: > * Doug Rabson [001119 04:29] wrote: >> dfr 2000/11/19 04:28:42 PST >> >> Modified files: >> sys/alpha/alpha clock.c db_interface.c interrupt.c >> mp_machdep.c prom.c vm_machdep.c >> Log: >> Convert various calls to splhigh() to disable_intr() since splhigh() is >> now a no-op. > > Afaik the concensus was that spl's were not to be removed even > though they are no-ops. More like that spl's shouldnt' be removed until they are replaced by locks or something else. There are actually several spl's lying around sched_lock that should probably be axed as they serve to simply clutter the code. > You should probably put them back. Perhaps if they are to be replaced with a lock later on. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message