From owner-svn-src-stable@freebsd.org  Wed Sep 16 11:15:09 2015
Return-Path: <owner-svn-src-stable@freebsd.org>
Delivered-To: svn-src-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A38139CE180;
 Wed, 16 Sep 2015 11:15:09 +0000 (UTC) (envelope-from ray@freebsd.org)
Received: from smtp.dlink.ua (smtp.dlink.ua [193.138.187.146])
 by mx1.freebsd.org (Postfix) with ESMTP id 617BC1B2A;
 Wed, 16 Sep 2015 11:15:09 +0000 (UTC) (envelope-from ray@freebsd.org)
Received: from terran (unknown [192.168.99.1]) (Authenticated sender: ray)
 by smtp.dlink.ua (Postfix) with ESMTPA id 65CE0C493A;
 Wed, 16 Sep 2015 14:15:01 +0300 (EEST)
Date: Wed, 16 Sep 2015 14:15:16 +0300
From: Aleksandr Rybalko <ray@freebsd.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Cc: Aleksandr Rybalko <ray@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-stable@freebsd.org,
 svn-src-stable-10@freebsd.org
Subject: Re: svn commit: r287782 - stable/10/sys/dev/vt
Message-Id: <20150916141516.eb45a2dc91e5b49aedd2c33b@freebsd.org>
In-Reply-To: <20150915013421.GA59565@FreeBSD.org>
References: <201509141442.t8EEg7ao012596@repo.freebsd.org>
 <20150915013421.GA59565@FreeBSD.org>
X-Mailer: Sylpheed 3.4.2 (GTK+ 2.24.25; amd64-portbld-freebsd10.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
 <svn-src-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable>, 
 <mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable/>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
 <mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Sep 2015 11:15:09 -0000

On Tue, 15 Sep 2015 01:34:21 +0000
Alexey Dokuchaev <danfe@FreeBSD.org> wrote:

> On Mon, Sep 14, 2015 at 02:42:07PM +0000, Aleksandr Rybalko wrote:
> > New Revision: 287782
> > URL: https://svnweb.freebsd.org/changeset/base/287782
> > 
> > Log:
> >   MFC: r272715
> >   	Allow vt(4) to disable terminal bell with
> >       `sysctl kern.vt.bell_enable=0`, similar as syscons(4) do.
> > [...]
> > +VT_SYSCTL_INT(enable_bell, 1, "Enable bell");
> 
> I think you've meant `sysctl kern.vt.enable_bell=0' in the commit log.

Yes.
Just copied message with mistake of original commit.
Sorry for that. :)

> 
> > +	if (!vt_enable_bell)
> > +		return;
> > +
> >  	if (vd->vd_flags & VDF_QUIET_BELL)
> >  		return;
> 
> Hm, I'm wondering why having another sysctl is required when there's already
> a way to shut the bell up with VDF_QUIET_BELL flag?

Many guys found sysctl way as most comfort. I have no objections,
because that way was present in the syscons(4).
Name was changed to more obvious one, since '.bell' may be treated
as type of bell, but switch just do enable/disable. 

> 
> Also, there's certain naming inconsistency between syscons(4) and vt(4).
> On my stable/8 laptop, I see this:
> 
>     $ sysctl -d hw.syscons.bell
>     hw.syscons.bell: enable bell
> 
> On my -CURRENT desktop, this:
> 
>     $ sysctl -d kern.vt.enable_bell
>     kern.vt.enable_bell: Enable bell
> 
> ./danfe

Thanks you, Alexey!

WBW
-- 
Aleksandr Rybalko <ray@freebsd.org>