From owner-cvs-all  Sun Oct 28 21:27:10 2001
Delivered-To: cvs-all@freebsd.org
Received: from rover.village.org (rover.bsdimp.com [204.144.255.66])
	by hub.freebsd.org (Postfix) with ESMTP
	id 812E837B406; Sun, 28 Oct 2001 21:27:00 -0800 (PST)
Received: from harmony.village.org (harmony.village.org [10.0.0.6])
	by rover.village.org (8.11.3/8.11.3) with ESMTP id f9T5QwV94687;
	Sun, 28 Oct 2001 22:26:58 -0700 (MST)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost [127.0.0.1])
	by harmony.village.org (8.11.6/8.11.6) with ESMTP id f9T5Qu785716;
	Sun, 28 Oct 2001 22:26:56 -0700 (MST)
	(envelope-from imp@harmony.village.org)
Message-Id: <200110290526.f9T5Qu785716@harmony.village.org>
To: Greg Lehey <grog@FreeBSD.org>
Subject: Re: Causing known breakage (was: cvs commit: src/sys/kern kern_conf.c subr_disk.c) 
Cc: Poul-Henning Kamp <phk@critter.freebsd.dk>, mjacob@feral.com,
	Jonathan Lemon <jlemon@flugsvamp.com>,
	"Andrey A. Chernov" <ache@nagual.pp.ru>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
In-reply-to: Your message of "Sun, 28 Oct 2001 19:02:25 +1030."
		<20011028190225.A88146@monorchid.lemis.com> 
References: <20011028190225.A88146@monorchid.lemis.com>  <20011028085000.O8085@wantadilla.lemis.com> <31408.1004257724@critter.freebsd.dk> 
Date: Sun, 28 Oct 2001 22:26:56 -0700
From: Warner Losh <imp@harmony.village.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

In message <20011028190225.A88146@monorchid.lemis.com> Greg Lehey writes:
: On Sunday, 28 October 2001 at  9:28:44 +0100, Poul-Henning Kamp wrote:
: > In message <20011028085000.O8085@wantadilla.lemis.com>, Greg Lehey writes:
: >
: >> I can't be bothered looking for a rule that says you shouldn't commit
: >> anything which will knowingly cause breakage, but if it's not in the
: >> book, it should be.  First ensure that cause of the breakage gets
: >> fixed, or fix it yourself.
: >
: > The kernel itself has been whining at making this mistake since
: > 11 sep 2000.
: >
: > That should be more than sufficient warning for anyone.
: 
: So why haven't you fixed it?
: 
: Seriously, though, you've got to admit that's rather irrelevant to the
: statement.

Ummm, maybe he doesn't have hardware?  Maybe driver authors have been
doing it wrong alll along and they've been lucky?

Come on Greg, I think you are going head to head with phk here over
him doing the right thing.

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message