From owner-svn-src-all@freebsd.org Sun Jun 3 20:24:26 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39E71FF7649 for ; Sun, 3 Jun 2018 20:24:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C64007A8C8 for ; Sun, 3 Jun 2018 20:24:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22a.google.com with SMTP id m194-v6so7671414itg.2 for ; Sun, 03 Jun 2018 13:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XAG3dTq6vXxS3zcSIAM5Hv/0G+LDAdrXf1LHQ7N/8mg=; b=gLfpsPY9Nid32lNI8t3ECtUxRAjqOc0lw2iZXJohXIEFr/LHP3nJkyFCZ32KKsCKSW lC544j42AZnV9z2V/b+rIESbuxk8qA33xyeVzH9zXgR80D7uNxD3Udy8TbTGDQncsuFe pnMVAlFkVrxtijBuuM0ClOzE3ybNTUlO7CpA7lwY8Q6bp7D0IiV3xMUFd1qVJK7pemK0 6l8ftwFFP06E/UX6wn7Fmu+OGUU4xJcSrymSbkD8Yq1NdswVsHy+XptXOrGEIcBdoi0X b2gy8J3EKbjP9spiLmS+S08OjzvEvJWz3eu897/8lK035Z7PNDAHQnu62M/U5m1lrHSR sKiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XAG3dTq6vXxS3zcSIAM5Hv/0G+LDAdrXf1LHQ7N/8mg=; b=j534bVuWbwGUAlQyZ9AtF8jHfr8WOwycdLGYgxRd3ll4IceDGNvbVKjxly7QL4hXR1 LMHUT3B1vZ1n4Jd2cx7y/BzHW7eHIeb4BWFHt3Va63WEUlEmntyginUbRGJNa/ZgA3dx CUNEYO9S+Ok1FbSBna5RgEjlF5fyuype2CAwyMLVYRySnmPEgIbCZQ8H7apRcBnDYCSD c6FfNj6IA2ypTXh/ZDcTcGd2iBRaw89t414GtuqX77blKIJM46FvSgzkuX5FCWwAklLA hcI7Hy2Jw0JSmH5O/4GAp2Zxhhw4q8vlS/QMrExaW2RbLA/2l550qalvVvmlD6G6EC68 ZzWg== X-Gm-Message-State: ALKqPwem6XBqYFl2IrXjZgCzxchDfVE9x98hmtuL5x1+1yA5w9s+bPoH rSSy/tZJweCfND1ZxUn9iUCq5+Ku17Hf5+K7S/J6gg== X-Google-Smtp-Source: ADUXVKJCRow3rKPW/M//zUwymwhABh8chkieK/r/NNAup8wsWh/RtfEnrEhKFWZd+M3pnNzkBa3GsDK9wZOYTC/gQjw= X-Received: by 2002:a24:5b81:: with SMTP id g123-v6mr9358878itb.1.1528057464973; Sun, 03 Jun 2018 13:24:24 -0700 (PDT) MIME-Version: 1.0 References: <201806030507.w5357kMm036583@repo.freebsd.org> In-Reply-To: <201806030507.w5357kMm036583@repo.freebsd.org> From: Warner Losh Date: Sun, 3 Jun 2018 14:24:13 -0600 Message-ID: Subject: Re: svn commit: r334552 - head/usr.bin/top To: Eitan Adler Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jun 2018 20:24:26 -0000 This came up a few days ago on tech-kern@netbsd.org mailing list as well... Warner On Sat, Jun 2, 2018, 11:07 PM Eitan Adler wrote: > Author: eadler > Date: Sun Jun 3 05:07:46 2018 > New Revision: 334552 > URL: https://svnweb.freebsd.org/changeset/base/334552 > > Log: > top(1): remove chdir to / > > While this came out of a conversation in IRC, it turn out that some > people don't like it. Since this was a courtesy feature, just remove it. > > Modified: > head/usr.bin/top/top.c > > Modified: head/usr.bin/top/top.c > > ============================================================================== > --- head/usr.bin/top/top.c Sun Jun 3 05:07:39 2018 (r334551) > +++ head/usr.bin/top/top.c Sun Jun 3 05:07:46 2018 (r334552) > @@ -260,15 +260,6 @@ main(int argc, char *argv[]) > #define CMD_order 26 > #define CMD_pid 27 > > - /* > - * Since top(1) is often long running and > - * doesn't typically care about where its running from > - * chdir to the root to allow unmounting of its > - * original wd. Failure is alright as this is > - * just a courtesy for users. > - */ > - chdir("/"); > - > /* set the buffer for stdout */ > #ifdef DEBUG > extern FILE *debug; > >