From owner-cvs-all Sun Oct 29 21:51:24 2000 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (flutter.freebsd.dk [212.242.40.147]) by hub.freebsd.org (Postfix) with ESMTP id 4843B37B479; Sun, 29 Oct 2000 21:51:20 -0800 (PST) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.1/8.9.3) with ESMTP id e9U5lUs03485; Mon, 30 Oct 2000 06:47:30 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Marcel Moolenaar Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: offsetof in stddef [was: Re: cvs commit: src/sys/conf param.c ... ] In-Reply-To: Your message of "Sun, 29 Oct 2000 18:54:51 PST." <39FCE2FB.98301D13@cup.hp.com> Date: Mon, 30 Oct 2000 06:47:30 +0100 Message-ID: <3483.972884850@critter> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <39FCE2FB.98301D13@cup.hp.com>, Marcel Moolenaar writes: >Poul-Henning Kamp wrote: >> >> phk 2000/10/29 08:57:42 PST >> >> Modified files: >> sys/conf param.c >> sys/dev/advansys adwlib.h >> sys/dev/aic7xxx aic7xxx_freebsd.h >> sys/dev/pdq pdqreg.h >> sys/i386/i386 genassym.c >> sys/i386/linux linux_genassym.c >> sys/i386/svr4 svr4_genassym.c >> Log: >> Remove unneeded #includes. > >Not completely unrelated: > >The reason stddef was included was for offsetof (at least for the >genassym files). This we don't have to do know, but shouldn't we also >define offsetof in stddef.h the same as in sys/types.h (in terms of >__offsetof) to avoid redundancy? Unless the commit has messed up on me we do. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message