From owner-freebsd-apache@FreeBSD.ORG Tue Feb 19 15:57:48 2013 Return-Path: Delivered-To: freebsd-apache@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 272E286B for ; Tue, 19 Feb 2013 15:57:48 +0000 (UTC) (envelope-from geoff@sea-incorporated.com) Received: from mail-ob0-f169.google.com (mail-ob0-f169.google.com [209.85.214.169]) by mx1.freebsd.org (Postfix) with ESMTP id EDD69F25 for ; Tue, 19 Feb 2013 15:57:47 +0000 (UTC) Received: by mail-ob0-f169.google.com with SMTP id ta14so6718688obb.28 for ; Tue, 19 Feb 2013 07:57:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-originating-ip:from:date:message-id :subject:to:content-type:x-gm-message-state; bh=2MBk2+FprLKpf3ENZN/Vf6dn/FpHIAHma/a1QPBxz4I=; b=iK/5QsAZsA9TPfl2Ly5fkLrQzpnEAJkh4A/2hyQRGSN5FMyHulRykoEiJD1xK+qYvR 5k/e9rq9lJIAE0Xb4Vc6OMXf0C+XQ2m46vnIrUdap14+b1KkIe/oF5YvkeNSqaY7ODc6 XzW0/Pu24c2Yi1X5uHO2r/ZPbW09GT64ZHWIhTshk0W75nTE/BVIg4OXRdjvAdcFEV2Z rlap42koi/7+GYTcROshcweXxEyOKfuX8tQ+noQ5x4rm1VndXnUgwV+Spjay1SawrS3S jqNJMKcfcE/NWqUuqO+vDaYJ0IQUGtPwzhQs3qF0jVpZvCsmLumQQKHHKC/tlqs1ph7I +Hww== X-Received: by 10.182.109.70 with SMTP id hq6mr7951849obb.4.1361289467133; Tue, 19 Feb 2013 07:57:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.81.69 with HTTP; Tue, 19 Feb 2013 07:57:26 -0800 (PST) X-Originating-IP: [209.74.10.193] From: Geoff Speicher Date: Tue, 19 Feb 2013 10:57:26 -0500 Message-ID: Subject: apache22-worker-mpm check for apr threads fails To: freebsd-apache@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQmhXYktw4YVqu5x09duXs1Mt0AhrQZBumfrN4e8ow6PlnDXtYlpMcBTgyZQDmAJYyldniXd X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Feb 2013 15:57:48 -0000 The check for APR threading support in the apache22 Makefile.modules file, which gets used when building the apache22-worker-mpm port, is broken. On a pristine 9.1 box with an up-to-date ports tree, attempting to build apache22-worker-mpm successfully builds its prerequisites, including devel/apr1 with threading enabled, but upon returning to apache22-worker-mpm the build dies with the following error: ===> apache22-worker-mpm-2.2.23_4 requires APR threads. Please rebuild APR with THREAD support. *** [all] Error code 1 This error occurs regardless of whether or not threading is enabled in APR. Cursory snooping leads me to think that this may have been broken by APR ports commit r312209. As a temporary workaround, I patched my copy with the following: --- Makefile.modules.orig 2013-02-19 10:33:58.000000000 -0500 +++ Makefile.modules 2013-02-19 10:41:40.000000000 -0500 @@ -22,7 +22,7 @@ .if exists(${APR_CONFIG}) APR_LIBS!= ${SH} ${APR_CONFIG} --libs | ${SED} -e 's/-//g' . if defined(APR_LIBS) && !empty(APR_LIBS) -_T=pthread +_T=lpthread . for lib in ${APR_LIBS} . if ${_T:M${lib}} APR_HAS_THREADS= yes This works if APR was rebuilt using the new flags but probably not otherwise. There must be a better way of determining thread support that will work regardless of which flags were use to compile APR, e.g. checking APR_HAS_THREADS in apr.h or something similar: # grep -r '#define APR_HAS_THREADS' /usr/local/include/apr* /usr/local/include/apr-1/apr.h:#define APR_HAS_THREADS 1 Then again, maybe just updating the Makefile (as above) and bumping the devel/apr1 PORTREVISION would work too.