From owner-svn-src-projects@FreeBSD.ORG  Tue Dec 18 20:45:20 2012
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id E3996594;
 Tue, 18 Dec 2012 20:45:20 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
 [IPv6:2001:470:1f10:75::2])
 by mx1.freebsd.org (Postfix) with ESMTP id B4F298FC1D;
 Tue, 18 Dec 2012 20:45:20 +0000 (UTC)
Received: from pakbsde14.localnet (unknown [38.105.238.108])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 1DD90B94B;
 Tue, 18 Dec 2012 15:45:20 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Alexander Motin <mav@freebsd.org>
Subject: Re: svn commit: r244249 - projects/calloutng/sys/dev/syscons
Date: Tue, 18 Dec 2012 15:42:30 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p22; KDE/4.5.5; amd64; ; )
References: <201212151044.qBFAiG70038633@svn.freebsd.org>
 <201212171509.55216.jhb@freebsd.org> <50CF8D3D.6030906@FreeBSD.org>
In-Reply-To: <50CF8D3D.6030906@FreeBSD.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201212181542.30789.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Tue, 18 Dec 2012 15:45:20 -0500 (EST)
Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2012 20:45:21 -0000

On Monday, December 17, 2012 4:23:09 pm Alexander Motin wrote:
> On 17.12.2012 22:09, John Baldwin wrote:
> > On Saturday, December 15, 2012 5:44:16 am Alexander Motin wrote:
> >> Author: mav
> >> Date: Sat Dec 15 10:44:16 2012
> >> New Revision: 244249
> >> URL: http://svnweb.freebsd.org/changeset/base/244249
> >>
> >> Log:
> >>    Switch syscons from timeout() to callout_reset_flags() and specify that
> >>    precision is not important there -- anything from 20 to 30Hz will be fine.
> >>
> >> Modified:
> >>    projects/calloutng/sys/dev/syscons/syscons.c
> >>    projects/calloutng/sys/dev/syscons/syscons.h
> >>
> >> Modified: projects/calloutng/sys/dev/syscons/syscons.c
> >>
> > ==============================================================================
> >> --- projects/calloutng/sys/dev/syscons/syscons.c	Sat Dec 15 10:30:06 2012	
> > (r244248)
> >> +++ projects/calloutng/sys/dev/syscons/syscons.c	Sat Dec 15 10:44:16 2012	
> > (r244249)
> >> @@ -504,6 +504,8 @@ sc_attach_unit(int unit, int flags)
> >>
> >>       sc = sc_get_softc(unit, flags & SC_KERNEL_CONSOLE);
> >>       sc->config = flags;
> >> +    callout_init(&sc->ctimeout, FALSE);
> >> +    callout_init(&sc->cblink, FALSE);
> >
> > Did you change the calling conventions for callout_init() in this branch?  In
> > HEAD the second argument is a flags variable (albeit with only a single flag
> > defined: CALLOUT_MPSAFE).  Thus, the common usage is to use 'callout_init(..,
> > 0);' for callouts that need Giant and 'callout_init(..., CALLOUT_MPSAFE);' for
> > those that do not need Giant.
> 
> No, I haven't. But man page still talks about "FALSE" value for mpsafe 
> argument and that confused me. Fixed. Thanks.

Ah, ok.  I think you have some other changes that used "TRUE" instead of
CALLOUT_MPSAFE as well.

-- 
John Baldwin