From owner-freebsd-standards  Tue Feb 26 23:59:36 2002
Delivered-To: freebsd-standards@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 34D0237B400; Tue, 26 Feb 2002 23:59:34 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id SAA12248;
	Wed, 27 Feb 2002 18:56:58 +1100
Date: Wed, 27 Feb 2002 18:57:27 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: "M. Warner Losh" <imp@village.org>
Cc: <mike@FreeBSD.ORG>, <standards@FreeBSD.ORG>
Subject: Re: Garrett's POSIX versions patch for review
In-Reply-To: <20020226.224449.28794535.imp@village.org>
Message-ID: <20020227184645.K47808-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-standards@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-standards.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-standards>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-standards>
X-Loop: FreeBSD.ORG

On Tue, 26 Feb 2002, M. Warner Losh wrote:

> I think that these diffs look good on the surface.  I agree that it
> would be nice to have a prisitine c99 env, but if that's hard to do,
> then I don't see waiting the rest of the changes.

I think they look bad on the surface :-).  E.g., using #if defined (...)
instead of #ifdef, and indenting preprocessor code are style bugs.
There are superflous underscores.

I don't remember any technical problems from when I reviewed the first
version of Garrett's patch.  The new __FOO_VISIBLE macros are much easier
to use than the old _FOO_VISIBLE[_BAR] ones.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-standards" in the body of the message