Date: Fri, 11 Jan 2019 15:40:25 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 234833] USES=autoreconf fails if a port uses gettext but user disables NLS port option Message-ID: <bug-234833-7788-Oti0wgR6gL@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-234833-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-234833-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234833 --- Comment #3 from Matthias Andree <mandree@FreeBSD.org> --- (In reply to Tijl Coosemans from comment #1) Tijl, Antoine, thanks for your proposal, but it doesn't hold water.=20 What you propose creates a build-time depends on gettext, which is unnecess= ary; OTOH USES=3Dautoreconf will go looking for autopoint without depending on i= t. My point is that either the framework will need to make sure that either: - it establishes that the unpacked distfile requires gettext, and creates proper _DEPENDS entries, - or that it establishes that gettext is not required, and then Mk/Uses/autoreconf.mk needs to set AUTOPOINT=3D${TRUE} in autoreconf's environment. We should check if the other tools that autoreconf might depend on are trea= ted in the same vain. With "the port uses gettext", I mean AM*GETTEXT() lines in configure.ac, no= t a formal USES=3Dgettext-whatever declaration. My current workaround that avoids pulling gettext in at run-time, and that works for mail/fetchmail, is: USES=3D autoreconf:build [...] # <- part of workaround OPTIONS_DEFINE=3D X11 NLS NTLM POP2 DOCS # <- note NLS listed NLS_USES=3D gettext NLS_CONFIGURE_ENABLE=3D nls # This is a workaround for a ports framework bug: # As of r489889 on 2019-01-10,=20 # USES=3Dautoreconf does not seem to get along with disabling the NLS optio= n, # because this would not install gettext-tools, omitting autopoint, # however the configure.ac requests GETTEXT, so autoreconf will barf. # Pulling in gettext-tools unconditionally (even with NLS off) would=20 # be excess and confuse users, so is not an option. # Thus we set USES=3Dautoreconf:build and run autoreconf by ourselves, # overriding AUTOPOINT=3Dtrue. # pre-configure-NLS-on: (cd ${WRKSRC} && ${LOCALBASE}/bin/autoreconf -f -i) # pre-configure-NLS-off: (cd ${WRKSRC} && ${SETENV} AUTOPOINT=3D${TRUE} ${LOCALBASE}/bin/autoreconf -f -i) --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234833-7788-Oti0wgR6gL>