From owner-freebsd-ports-bugs@FreeBSD.ORG Thu May 27 10:30:04 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 642E51065675 for ; Thu, 27 May 2010 10:30:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (unknown [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 52E4B8FC25 for ; Thu, 27 May 2010 10:30:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o4RAU32A013126 for ; Thu, 27 May 2010 10:30:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o4RAU30v013121; Thu, 27 May 2010 10:30:03 GMT (envelope-from gnats) Date: Thu, 27 May 2010 10:30:03 GMT Message-Id: <201005271030.o4RAU30v013121@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Anonymous Cc: Subject: Re: ports/147103: [patch] editors/emacs-nox11: skip OPTIONS and use WITHOUT_DBUS X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Anonymous List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 May 2010 10:30:04 -0000 The following reply was made to PR ports/147103; it has been noted by GNATS. From: Anonymous To: wahjava@gmail.com (Ashish SHUKLA) Cc: phoffman@proper.com, Giorgos Keramidas , bug-followup@FreeBSD.org Subject: Re: ports/147103: [patch] editors/emacs-nox11: skip OPTIONS and use WITHOUT_DBUS Date: Thu, 27 May 2010 10:24:18 +0000 wahjava@gmail.com (Ashish SHUKLA) writes: > Refer to the attached diff file. > @@ -227,4 +224,12 @@ > @${INSTALL_DATA} ${WRKSRC}/sources.el ${DATADIR}/${EMACS_VER}/site-lisp/site-start.el > .endif > +pre-everything:: > + @${ECHO_MSG} > + @${ECHO_MSG} "====> By default Emacs is built with X11, DBUS, and GTK+ support." > + @${ECHO_MSG} "====> To disable X11 support, define: WITHOUT_X11." > + @${ECHO_MSG} "====> To disable GTK2 support, define: WITHOUT_GTK2." > + @${ECHO_MSG} "====> To disable DBUS support, define: WITHOUT_DBUS." > + @${ECHO_MSG} > + And what's going to be used when WITHOUT_GTK2 is defined? All other toolkits are disabled by default. I think only WITHOUT_X11 needs special mentioning in pre-everything target. DBUS is listed in OPTIONS. Besides, the target isn't going to be seen if BATCH is not defined and there are no options in PORT_DBDIR. dialog(1) will quickly replace it with blue screen with knobs. ;) And OPTIONS description should be a little more verbose. `support' is a very vague word. It's applied equally e.g. to PNG and MOTIF. I think toolkits should use smth like "Use Athena/Athena3d/Motif for drawing GUI instead of GTK2" s/GUI/widgets/ if you like latter more. And for images --- a.diff begins here --- diff --git editors/emacs/Makefile editors/emacs/Makefile index e1d6c6b..f2ee7f0 100644 --- editors/emacs/Makefile +++ editors/emacs/Makefile @@ -47,23 +47,23 @@ INFO= ada-mode auth autotype calc ccmode cl dbus dired-x \ OPTIONS= DBUS "DBus support" ON \ GCONF "GConf support" ON \ - GIF "GIF support" ON \ - JPEG "JPEG support" ON \ - M17N "M17N support for text-shaping" ON \ - MOTIF "Motif support" OFF \ - OTF "Opentype Font" ON \ - PNG "PNG support" ON \ + GIF "Support .gif images" ON \ + JPEG "Support .jpg images" ON \ + M17N "Use m17n for text-shaping" ON \ + MOTIF "Use Motif for drawing GUI instead of GTK2" OFF \ + OTF "Support OpenType fonts" ON \ + PNG "Support .png images" ON \ SOUND "Sound support" ON \ SOURCES "Install source code" ON \ - SVG "SVG support" ON \ - TIFF "TIFF support" ON \ - XAW "XAW support" OFF \ - XAW3D "XAW3D support" OFF \ + SVG "Support .svg images" ON \ + TIFF "Support .tif images" ON \ + XAW "Use Athena for drawing GUI instead of GTK2" OFF \ + XAW3D "Use Athena3D for drawing GUI instead of GTK2" OFF \ SYNC_INPUT "Synchronously process asynchronous input" ON \ SCROLLBARS "Without toolkit scroll-bars" ON \ - XFT "Xft support" ON \ - XIM "XIM support" ON \ - XPM "XPM support" ON + XFT "Support FreeType fonts" ON \ + XIM "Support X Input Method" ON \ + XPM "Support .xpm images" ON .include @@ -228,10 +228,7 @@ post-install: pre-everything:: @${ECHO_MSG} - @${ECHO_MSG} "====> By default Emacs is built with X11, DBUS, and GTK+ support." @${ECHO_MSG} "====> To disable X11 support, define: WITHOUT_X11." - @${ECHO_MSG} "====> To disable GTK2 support, define: WITHOUT_GTK2." - @${ECHO_MSG} "====> To disable DBUS support, define: WITHOUT_DBUS." @${ECHO_MSG} .include --- a.diff ends here ---