From owner-freebsd-stable@freebsd.org Wed Aug 26 08:29:03 2015 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED8A599A4D3 for ; Wed, 26 Aug 2015 08:29:02 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-pa0-x231.google.com (mail-pa0-x231.google.com [IPv6:2607:f8b0:400e:c03::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BAE032E4 for ; Wed, 26 Aug 2015 08:29:02 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by pacdd16 with SMTP id dd16so153412998pac.2 for ; Wed, 26 Aug 2015 01:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=xTQZtZyqTEHqqK4q32rSmiyJS79OImdk0wPsVvti6Wo=; b=lkLDOC1zo5W6Q3PZQG19vTuVuDG/OFe3BQqynGNb/2+KyQalxchHfFeexibAwq5MO/ uMw1tYQBP38ZkVx2uaX3qGXxmQnhaFCM13HZEfbR5ei5udmWw/Y07hxj7ks2/or/pJip Ls6g8C58w6qbo1MqW/h2jWs8DyMkXAUSbpjGbe8Ky6GusgOMIqJc2eH3LmaHwmLomDb8 yNPU0Qv6nAsKMaz9aCQeapXMgOL7lwmMBcmeUE9dJvLut92/rUWjGu1K94rS6k4ZFILP uDTXUThcfrdPpU9pWG0bFwtJ+rNfztjzfPbi3wbiBgWs86ZkwTQ4To8i+klfCLSAYeJp 9uUA== X-Received: by 10.67.30.161 with SMTP id kf1mr67283145pad.89.1440577742348; Wed, 26 Aug 2015 01:29:02 -0700 (PDT) Received: from pyunyh@gmail.com ([106.247.248.2]) by smtp.gmail.com with ESMTPSA id pe1sm23728576pbb.28.2015.08.26.01.28.58 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 26 Aug 2015 01:29:01 -0700 (PDT) From: Yonghyeon PYUN X-Google-Original-From: "Yonghyeon PYUN" Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Wed, 26 Aug 2015 17:28:50 +0900 Date: Wed, 26 Aug 2015 17:28:50 +0900 To: Johann Hugo Cc: Roosevelt Littleton , freebsd-stable@freebsd.org Subject: Re: msk msk0 watchdog timeout freeze hang lock stop problem Message-ID: <20150826082850.GC971@michelle.fasterthan.com> Reply-To: pyunyh@gmail.com References: <20150816120831.GB1288@michelle.fasterthan.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Qxx1br4bt0+wmkIi" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2015 08:29:03 -0000 --Qxx1br4bt0+wmkIi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 26, 2015 at 10:06:29AM +0200, Johann Hugo wrote: > 10.2-RELEASE does not work for me. It works for a very short while and > then it stops with "msk0 watchdog timeout" errors > Thanks a lot for your report. This is the first report for msk(4) watchdog timeouts on 10.2-RELEASE. > I'm not sure what patch Roosevelt was talking about, but the patch in > this thread works for me: > https://lists.freebsd.org/pipermail/freebsd-stable/2015-April/082226.html > > I've changed MSK_STAT_ALIGN from 4096 to 8192 in if_mskreg.h and it's > been running stable for the last week. > I see. I'm under the impression that RX/TX descriptor ring alignment shall trigger the same issue so it would be better to know how attached patch works on your box. Thanks. > Johann > > On Sun, Aug 16, 2015 at 2:08 PM, Yonghyeon PYUN wrote: > > On Wed, Aug 12, 2015 at 09:44:06AM -0400, Roosevelt Littleton wrote: > >> Hi, > >> So, I can confirm with the attached patch. I have a working msk0 that > >> hasn't failed for the past month. I considered this problem fix for me. > >> Since, I have went a long time without any problems. Thanks! > > > > I'm not sure which patch you used. Given that users reported > > 10.2-RELEASE works, it would be great if you revert local patch > > and try it again on 10.2-RELEASE. --Qxx1br4bt0+wmkIi Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="msk.align.diff" Index: sys/dev/msk/if_mskreg.h =================================================================== --- sys/dev/msk/if_mskreg.h (revision 281587) +++ sys/dev/msk/if_mskreg.h (working copy) @@ -2175,13 +2175,8 @@ #define MSK_ADDR_LO(x) ((uint64_t) (x) & 0xffffffffUL) #define MSK_ADDR_HI(x) ((uint64_t) (x) >> 32) -/* - * At first I guessed 8 bytes, the size of a single descriptor, would be - * required alignment constraints. But, it seems that Yukon II have 4096 - * bytes boundary alignment constraints. - */ -#define MSK_RING_ALIGN 4096 -#define MSK_STAT_ALIGN 4096 +#define MSK_RING_ALIGN 32768 +#define MSK_STAT_ALIGN 32768 /* Rx descriptor data structure */ struct msk_rx_desc { --Qxx1br4bt0+wmkIi--