From owner-svn-ports-all@FreeBSD.ORG Sat Feb 7 01:40:57 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AF718D03 for ; Sat, 7 Feb 2015 01:40:57 +0000 (UTC) Received: from vfemail.net (nine.vfemail.net [108.76.175.9]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D5BE8D62 for ; Sat, 7 Feb 2015 01:40:56 +0000 (UTC) Received: (qmail 34577 invoked by uid 89); 7 Feb 2015 01:40:32 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 7 Feb 2015 01:40:32 -0000 Received: (qmail 33852 invoked by uid 89); 7 Feb 2015 00:14:02 -0000 Received: by simscan 1.3.1 ppid: 33830, pid: 33844, t: 1.9920s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 7 Feb 2015 00:14:00 -0000 Received: (qmail 30896 invoked by uid 89); 7 Feb 2015 00:13:54 -0000 Received: by simscan 1.4.0 ppid: 30857, pid: 30891, t: 0.7742s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by 172.16.100.62 with ESMTPA; 7 Feb 2015 00:13:53 -0000 From: Jan Beich To: Rene Ladan Subject: Re: svn commit: r378563 - in head/www/chromium: . files References: <201502062228.t16MSqq8072725@svn.freebsd.org> Date: Sat, 07 Feb 2015 01:13:43 +0100 In-Reply-To: (Jan Beich's message of "Sat, 07 Feb 2015 01:04:44 +0100") Message-ID: <61be-h93c-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, John Marino , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Feb 2015 01:40:57 -0000 Sorry, typos creep in... <#secure method=pgpmime mode=sign> Jan Beich writes: >>> ++# elif __FreeBSD_version__ < 900031 >> >> Have you made sure __FreeBSD_version__ is defined? > > Also, __FreeBSD_version has no underscores at the end. > >> >>> ++ return 0; /* ! */ >> >> Maybe replace with >> >> #include >> ... >> long lwpid; >> thr_self(&lwpid); >> return static_cast(lwpid); > > Attached in a patch form. I haven't actually tested it builds. Missed sys/thr.h and probably better to use sys/param.h in case someone adds GNU/kFreeBSD support. Index: www/chromium/files/patch-v8__src__base__platform__platform-posix.cc =================================================================== --- www/chromium/files/patch-v8__src__base__platform__platform-posix.cc (revision 378569) +++ www/chromium/files/patch-v8__src__base__platform__platform-posix.cc (working copy) @@ -1,17 +1,37 @@ --- v8/src/base/platform/platform-posix.cc.orig 2015-01-27 03:22:59.000000000 +0100 +++ v8/src/base/platform/platform-posix.cc 2015-02-06 18:41:53.881294389 +0100 -@@ -259,6 +259,14 @@ +@@ -54,6 +54,15 @@ + #include // NOLINT, for prctl + #endif + ++#if V8_OS_FREEBSD ++#include // for __FreeBSD_version ++#include // for thr_self ++#endif ++ ++#if V8_OS_NETBSD ++#include // for _lwp_self ++#endif ++ + #if !V8_OS_NACL + #include + #endif +@@ -259,6 +268,18 @@ int OS::GetCurrentThreadId() { return static_cast(syscall(__NR_gettid)); #elif V8_OS_ANDROID return static_cast(gettid()); ++#elif V8_OS_DRAGONFLYBSD || defined(__DragonFly__) ++ return static_cast(lwp_gettid()); +#elif V8_OS_FREEBSD -+# ifdef __DragonFly__ -+ return static_cast(lwp_gettid()); -+# elif __FreeBSD_version__ < 900031 -+ return 0; /* ! */ ++# if __FreeBSD_version < 900031 ++ long lwpid; ++ thr_self(&lwpid); ++ return static_cast(lwpid); +# else + return static_cast(pthread_getthreadid_np()); +# endif ++#elif V8_OS_NETBSD ++ return static_cast(_lwp_self()); #else return static_cast(pthread_self()); #endif ------------------------------------------------- VFEmail.net - http://www.vfemail.net ONLY AT VFEmail! - Use our Metadata Mitigator to keep your email out of the NSA's hands! $24.95 ONETIME Lifetime accounts with Privacy Features! 15GB disk! No bandwidth quotas! Commercial and Bulk Mail Options!