From owner-svn-src-all@freebsd.org Mon Nov 2 11:47:25 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE67AA234BA; Mon, 2 Nov 2015 11:47:25 +0000 (UTC) (envelope-from mmel@freebsd.org) Received: from mail.miracle.cz (mail.miracle.cz [193.84.128.19]) by mx1.freebsd.org (Postfix) with ESMTP id 9ECC11808; Mon, 2 Nov 2015 11:47:25 +0000 (UTC) (envelope-from mmel@freebsd.org) Received: from [193.84.128.50] (meloun.ad.miracle.cz [193.84.128.50]) by mail.miracle.cz (Postfix) with ESMTPSA id 5E510ACAD34; Mon, 2 Nov 2015 12:47:18 +0100 (CET) Subject: Re: svn commit: r290234 - head/share/misc To: Gleb Smirnoff , Alexey Dokuchaev References: <201511011654.tA1GstJP054578@repo.freebsd.org> <20151102071346.GA12970@FreeBSD.org> <20151102103757.GE78469@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org From: Michal Meloun X-Enigmail-Draft-Status: N1110 Organization: freebsd.org Message-ID: <56374D46.9040506@freebsd.org> Date: Mon, 2 Nov 2015 12:47:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151102103757.GE78469@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.miracle.cz); Mon, 02 Nov 2015 12:47:18 +0100 (CET) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 11:47:26 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Dne 02.11.2015 v 11:37 Gleb Smirnoff napsal(a): > On Mon, Nov 02, 2015 at 07:13:46AM +0000, Alexey Dokuchaev wrote: > A> On Sun, Nov 01, 2015 at 04:54:55PM +0000, Michal Meloun wrote: > A> > New Revision: 290234 A> > URL: > https://svnweb.freebsd.org/changeset/base/290234 A> > A> > Log: A> > > Install myself as src committer. A> > A> > Approved by: kib > (mentor) A> > > Description of fields to fill in above: > 76 columns --| A> > [ garbage omitteed ] A> A> Here is a small > advice: do not rely on "svn ci" calling your $EDITOR for A> you, > compose the message yourself first and then do "svn ci -F > $logfile". A> For one-liners, "svn ci -m message" works even > better. > > Alternatively: rely on $EDITOR, but don't trust the line: > > --This line, and those below, will be ignored-- > > Finalize your message manually. > > P.S. Not that there is bugs in the svn, but you can have touched > the line. > I'm sorry to all, it’s my bug. Commit using editor (but using git) is standard practice here @work. So I automatically select same workflow for FreeBSD. Anyway, I already got hit from kib@, so I'll use a file for commit log next time. But i'm pretty sure that i have not touched template. I only deleted all prepared unfilled lines (for PR:, MFC: ...) and then i paste commit message. And, ironically, only - --This line, and those below, will be ignored-- line has been omitted from real commit log. Michal -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWN01GAAoJEGkesmtexaqqGvEIAICYBFTeblZZ+C3Y82JqN97h fnFHNG0wyJEhj9a4jDBWyAJldU4kesa2XHw2I8dGIUB9Iz+Vp0nnib5WIvhWPL7S t1NdQDyy9MELAXx0v4wNnyDexl+YYM9nEGvQokesFV/V0vI+6WctjMM8S8tnRs1e hVu80ZgbvJOTTV6OuNl9/Cjo4oPeh3IWZMlLuYP95pV4vzlgoF6CPimrdki8gVMX dW/9DUIJd1bX73LYoCtwfM0WZEFFbbgrpBO8DJbSWEmx1hJUQmk5mYE8jUYDk9Ot 8wxE+3n1g5ovZUQGREiR5s+3xu7MJ8PSroLIM69kJUvER0pAedXkDphYm/l8v8g= =s8VI -----END PGP SIGNATURE-----