From owner-freebsd-current@FreeBSD.ORG Tue Jul 12 21:41:17 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B484F106564A; Tue, 12 Jul 2011 21:41:17 +0000 (UTC) (envelope-from gleb.kurtsou@gmail.com) Received: from mail-fx0-f44.google.com (mail-fx0-f44.google.com [209.85.161.44]) by mx1.freebsd.org (Postfix) with ESMTP id 0D9308FC1D; Tue, 12 Jul 2011 21:41:16 +0000 (UTC) Received: by fxe6 with SMTP id 6so4419696fxe.17 for ; Tue, 12 Jul 2011 14:41:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=jbJPJCnt3m6WYYSXjrun37geQaFp7EzImmLa48kbaJ0=; b=NACn/W5xFcYyia1eV/Kxcl18MHHIssdC5+XAYgAummiQZO+DlypT4Bi5M8yOs5KFjG LjGGIIa2RL+UxsZg5wXKw6iwfqgYw9T3Ah61W4plsGv/bY98Yi6qrV48TDOlk68Yhafu sEtHob1zkDZ5nCGXQGEm9wHHg4st8JqvX5WTM= Received: by 10.223.67.194 with SMTP id s2mr521369fai.124.1310506875833; Tue, 12 Jul 2011 14:41:15 -0700 (PDT) Received: from localhost (lan-78-157-92-5.vln.skynet.lt [78.157.92.5]) by mx.google.com with ESMTPS id l9sm7006900fal.19.2011.07.12.14.41.13 (version=SSLv3 cipher=OTHER); Tue, 12 Jul 2011 14:41:14 -0700 (PDT) Date: Wed, 13 Jul 2011 00:40:49 +0300 From: Gleb Kurtsou To: mdf@FreeBSD.org Message-ID: <20110712214049.GA12290@tops> References: <20110707015151.GB71966@troutmask.apl.washington.edu> <4E1B67C7.8040402@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Ali Mashtizadeh , FreeBSD Current , Arnaud Lacombe Subject: Re: Heavy I/O blocks FreeBSD box for several seconds X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2011 21:41:17 -0000 On (11/07/2011 16:36), mdf@FreeBSD.org wrote: > On Mon, Jul 11, 2011 at 4:00 PM, Ali Mashtizadeh wrote: > > Maybe someone can setup something like reviewboard [1] for developers > > to use. This may also help folks who want to keep abreast of the > > current work in a particular subsystem or get involved into the > > development process more. At my company we use reviews and it seems to > > help the catch some bugs and help new engineers ramp up faster. > > > > [1] http://www.reviewboard.org/ > > FreeBSD development is completely open; anyone can sign up for the > svn-src-* mailing list they are interested in, including > svn-src-head@. Code reviews are plenty as well; just check the list > archives for discussion of bugs, poor design choices and unintended > effects. But most reviews are silent and after-the-fact by looking at > the list mail. It's a system that seems to be working just fine for > the FreeBSD project so far. This isn't a job for most anyone; it's a > volunteer project and so anything that raises the barrier to getting > work done for the project should be looked at with skepticism. I agree with everything said above and think that it's not reviews that's missing. By review I don't mean something like getting "ok to commit" reply from N developers before committing. svn-src@ works great for it, commits keep getting reverted :) Review is a time consuming process that also requires certain level of expertise. Volunteer project can hardly afford it. Having a project adopted way of sharing work in progress will be a step forward. Yes, I'm aware of perforce, it's to hard to use and wasn't designed to share and test ideas. I think guthub can be a very good candidate (but AFAIK it won't allow hosting of FreeBSD repo for not paid accounts). I'm not suggesting switching to git as VCS, but using github UI for communication and tracking not yet commited or work in progress changes. In ideal world developers will merge patches from each other increasing chance of a good code to survive and get commited later. Currently we have patches hosted at people.freebsd.org, as attachments on maillists and PRs -- almost all stale or outdated. Key difference of github is that original patch author will be aware of you using it, potentially updating and improving it. Others can continue supporting the patch if original author abandons it, etc. Sending patches is too complicated and counterproductive comparing to github. Thanks, Gleb. > > Is there a specific deficit that you want to address? > > Thanks, > matthew