From owner-freebsd-geom@FreeBSD.ORG Sun Mar 8 23:21:47 2015 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B401C9CA for ; Sun, 8 Mar 2015 23:21:47 +0000 (UTC) Received: from thyme.infocus-llc.com (thyme.infocus-llc.com [199.15.120.10]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 89E1F78D for ; Sun, 8 Mar 2015 23:21:47 +0000 (UTC) Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net [75.65.60.66]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by thyme.infocus-llc.com (Postfix) with ESMTPSA id 07D5B37B5CD; Sun, 8 Mar 2015 18:21:46 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 3l0dx53Qvcz2PY; Sun, 8 Mar 2015 18:21:45 -0500 (CDT) Date: Sun, 8 Mar 2015 18:21:45 -0500 From: "Matthew D. Fuller" To: Steven Hartland Subject: Re: RFC: Pass TRIM through GELI Message-ID: <20150308232145.GT1742@over-yonder.net> References: <20150308000131.GP1742@over-yonder.net> <54FC4E99.4080202@multiplay.co.uk> <20150308223552.GR1742@over-yonder.net> <54FCCFC3.4000007@multiplay.co.uk> <20150308225046.GS1742@over-yonder.net> <54FCD5B9.3090101@multiplay.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54FCD5B9.3090101@multiplay.co.uk> X-Editor: vi X-OS: FreeBSD User-Agent: Mutt/1.5.23-fullermd.4 (2014-03-12) X-Virus-Scanned: clamav-milter 0.98.6 at thyme.infocus-llc.com X-Virus-Status: Clean Cc: freebsd-geom@freebsd.org X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Mar 2015 23:21:47 -0000 On Sun, Mar 08, 2015 at 11:05:29PM +0000 I heard the voice of Steven Hartland, and lo! it spake thus: > > IIRC ufs doesn't support TRIM by default, it needs to be manually > enabled. But if you `newfs -t` it, and then mount on a stack that doesn't support TRIM, it notices and doesn't send any BIO_DELETE's. > GELI is kind of different though given is use, I'm sure users of it > would expect delete to leave no trace of the data which was there, > which is what I was under the impression it does, correct me if I'm > wrong? Oh, I see where you're coming from. No, there's a comment suggesting it could shred the data, but that's never been implemented. The current code just falls through to the default case of the switch and denies it: . case BIO_DELETE: . . /* . . * We could eventually support BIO_DELETE request. . . * It could be done by overwritting requested sector with . . * random data g_eli_overwrites number of times. . . */ . default: . . g_io_deliver(bp, EOPNOTSUPP); . . return; -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream.