From owner-freebsd-ports@FreeBSD.ORG Wed Feb 9 16:09:32 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 32AAA1065672 for ; Wed, 9 Feb 2011 16:09:32 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id AC5338FC13 for ; Wed, 9 Feb 2011 16:09:31 +0000 (UTC) Received: by gyc15 with SMTP id 15so137876gyc.13 for ; Wed, 09 Feb 2011 08:09:31 -0800 (PST) Received: by 10.151.102.20 with SMTP id e20mr1908363ybm.87.1297267769796; Wed, 09 Feb 2011 08:09:29 -0800 (PST) Received: from sunpoet.net (sunpoet.net [220.133.12.240]) by mx.google.com with ESMTPS id q4sm972182ybe.12.2011.02.09.08.09.27 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 09 Feb 2011 08:09:28 -0800 (PST) Received: by sunpoet.net (Postfix, from userid 1000) id B814E2AEC6C9; Thu, 10 Feb 2011 00:10:08 +0800 (CST) Date: Thu, 10 Feb 2011 00:10:08 +0800 From: Sunpoet Hsieh To: arrowdodger <6yearold@gmail.com> Message-ID: <20110209161008.GD87684@bonjour.sunpoet.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: Organization: The FreeBSD Project User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-ports@freebsd.org Subject: Re: Request for new port review: TortoiseHG. X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2011 16:09:32 -0000 On Wed, Feb 09, 2011 at 06:24:34PM +0300, arrowdodger wrote: > On Wed, Feb 9, 2011 at 4:42 PM, Sunpoet Hsieh wrote: >=20 > > It looks like you'll have two ports, version 1 and 2, and these two > > ports do not conflict with each other. > > IMHO, I would simply use devel/tortoisehg1 for version 1 and > > devel/tortoisehg for upcoming version 2. > > You do not need to add -gtk or -pyqt suffix to emphasize the use of GTK= or > > Qt. > > > Okay. >=20 > Now regarding this: >=20 > > >> In your case, it can be done without extra patch files. > > >> > > >> .if !defined(WITH_NAUTILUS) > > >> @${REINPLACE_CMD} -e '153,154 D' ${WRKSRC}/${PYSETUP} > > >> .endif > > >> .if !defined(WITH_NLS) > > >> @${REINPLACE_CMD} -e '150,152 D' ${WRKSRC}/${PYSETUP} > > >> .endif > > > -e 'x,y D' removes whole line, so all lines under removed line get shifte= d. > So, it's impossible to apply them in all combinations. > I'm not familiar with sed, but is it possible to delete whole line, but > leave \n at the end so line numbers will not be shifted? You're right. I'll use @${REINPLACE_CMD} -e '153,154 s|^|# |' ${WRKSRC}/${PYSETUP} instea= d. > PYDISTUTILS_EGGINFO defaults to > > > > ${PYDISTUTILS_PKGNAME:C/[^A-Za-z0-9.]+/_/g}-${PYDISTUTILS_PKGVERSION:C/= [^A-Za-z0-9.]+/_/g}-${PYTHON_VERSION:S/thon//}.egg-info > > (Mk/bsd.python.mk, around line 509) > > > > For Python versions, see PYTHON_VERSION, PYTHON_PORTVERSION and PYTHON_= VER. > > (Mk/bsd.python.mk, around line 372-410) > > > Okay, i will look there. >=20 > By the way, currently 'make fetch' does not work, because hosting site ha= ve > broken certs. So, i was forced to do this: > RUN_DEPENDS=3D hg:${PORTSDIR}/devel/mercurial \ > wget:${PORTSDIR}/ftp/wget >=20 > FETCH_CMD=3Dwget > FETCH_BEFORE_ARGS=3D--no-check-certificate >=20 > Is it ok? First, it should be FETCH_DEPENDS, not RUN_DEPENDS. Back to the download problem, make fetch fails due to the default FETCH_ARG= S (-AFpr). -A flag denies "301/302 redirect" used by bitbucket.org to redirect request= s to the destination. It finally goes to cdn.bitbucket.org. Therefore, you have two options: 1. Set MASTER_SITES=3Dhttp://cdn.bitbucket.org/tortoisehg/targz/downloads/ = to skip redirection. 2. Set FETCH_ARGS=3D-Fpr to allow redirect. I prefer 1. Detailed logs shown as follows: % make fetch =3D> tortoisehg-1.1.9.1.tar.gz doesn't seem to exist in /usr/ports/distfile= s/. =3D> Attempting to fetch http://bitbucket.org/tortoisehg/targz/downloads//t= ortoisehg-1.1.9.1.tar.gz looking up bitbucket.org connecting to bitbucket.org:80 requesting http://bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1.1.9= =2E1.tar.gz 301 redirect to https://bitbucket.org/tortoisehg/targz/downloads/tortoisehg= -1.1.9.1.tar.gz looking up bitbucket.org connecting to bitbucket.org:443 SSL connection established using DHE-RSA-AES256-SHA Certificate subject: /C=3DNL/O=3Dbitbucket.org/OU=3DGT16385137/OU=3DSee www= =2Egeotrust.com/resources/cps (c)09/OU=3DDomain Control Validated - QuickSS= L(R)/CN=3Dbitbucket.org Certificate issuer: /C=3DUS/O=3DEquifax/OU=3DEquifax Secure Certificate Aut= hority requesting https://bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1.1.= 9.1.tar.gz 302 redirect to http://cdn.bitbucket.org/tortoisehg/targz/downloads/tortois= ehg-1.1.9.1.tar.gz looking up cdn.bitbucket.org connecting to cdn.bitbucket.org:80 requesting http://cdn.bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1= =2E1.9.1.tar.gz remote size / mtime: 6815613 / 1296700276 Best regards, --=20 Sunpoet Po-Chuan Hsieh 4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B http://people.FreeBSD.org/~sunpoet/pgpkeys.txt