From owner-freebsd-current@FreeBSD.ORG  Mon Mar  3 20:26:41 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1DF231065671
	for <current@freebsd.org>; Mon,  3 Mar 2008 20:26:41 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247])
	by mx1.freebsd.org (Postfix) with ESMTP id D97DC8FC1A
	for <current@freebsd.org>; Mon,  3 Mar 2008 20:26:40 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 2F2D7675EC0
	for <current@freebsd.org>; Mon,  3 Mar 2008 21:09:58 +0100 (CET)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id rEAIjobjcLFk for <current@freebsd.org>;
	Mon,  3 Mar 2008 21:09:47 +0100 (CET)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 25E48675EC2
	for <current@freebsd.org>; Mon,  3 Mar 2008 21:09:47 +0100 (CET)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id m23K9kZa079235
	for current@freebsd.org; Mon, 3 Mar 2008 21:09:46 +0100 (CET)
	(envelope-from rdivacky)
Date: Mon, 3 Mar 2008 21:09:46 +0100
From: Roman Divacky <rdivacky@freebsd.org>
To: current@freebsd.org
Message-ID: <20080303200946.GA79061@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.2.3i
Cc: 
Subject: shared lock instead of exclusive in set_rootvnode
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Mar 2008 20:26:41 -0000

hi

in set_rootvnode() there is 

p->p_fd->fd_cdir = rootvnode;
p->p_fd->fd_rdir = rootvnode;

protected just by FILEDESC_SLOCK(), I dont think this is correct
although it might be benign as this is used only during boot.

still, if it's not correct it should be fixed

comments?

roman