Date: Sat, 27 Apr 2019 17:23:00 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346788 - head/sys/arm/allwinner/clkng Message-ID: <20190427172300.eee4575d5a4049b5b11de741@bidouilliste.com> In-Reply-To: <201904271456.x3REuOtV097621@repo.freebsd.org> References: <201904271456.x3REuOtV097621@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 27 Apr 2019 14:56:24 +0000 (UTC) Emmanuel Vadot <manu@FreeBSD.org> wrote: > Author: manu > Date: Sat Apr 27 14:56:24 2019 > New Revision: 346788 > URL: https://svnweb.freebsd.org/changeset/base/346788 >=20 > Log: > arm64: allwinner: ccu_de2: Remove H5 compatible > =20 > We don't have the display engine driver commited in FreeBSD yet so it is > useless to expose the clocks yet (and also it have not been tested on H= 5). My initial though were wrong. I though I've never tested the clocks on H5 but I did (but the full display engine wasn't tested). What happened is that since r346271 aw_rtc now attaches at BUS_PASS_BUS + MIDDLE as it exposes clocks used by the ccu (clock and control unit) and the CCU attaches at BUS_PASS_BUS + LAST which is the same bus pass as the de2_ccu. Since the de2ccu node is before the ccu node in the DTB it is processed first. A proper fix would be to check if the needed clocks are already registed in the probe function. And this I guess a lots of driver will need this I'll see how to make a generic function that drivers could use. =20 > Reported by: Manuel St=FChn (freebsdnewbie@freenet.de) > PR: 237571 > MFC after: 1 week >=20 > Modified: > head/sys/arm/allwinner/clkng/ccu_de2.c >=20 > Modified: head/sys/arm/allwinner/clkng/ccu_de2.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/arm/allwinner/clkng/ccu_de2.c Sat Apr 27 14:48:27 2019 (r346= 787) > +++ head/sys/arm/allwinner/clkng/ccu_de2.c Sat Apr 27 14:56:24 2019 (r346= 788) > @@ -115,7 +115,6 @@ static struct aw_ccung_clk de2_ccu_clks[] =3D { > =20 > static struct ofw_compat_data compat_data[] =3D { > {"allwinner,sun50i-a64-de2-clk", 1}, > - {"allwinner,sun50i-h5-de2-clk", 1}, > {NULL, 0} > }; > =20 --=20 Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190427172300.eee4575d5a4049b5b11de741>