Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Jan 2020 04:59:34 +0000
From:      bugzilla-noreply@freebsd.org
To:        gecko@FreeBSD.org
Subject:   [Bug 243252] www/firefox core dumps after r522486 (failed to freeze shm)
Message-ID:  <bug-243252-21738-HM6QfBMWQ5@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-243252-21738@https.bugs.freebsd.org/bugzilla/>
References:  <bug-243252-21738@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243252

Mikhail Teterin <mi@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mi@FreeBSD.org

--- Comment #13 from Mikhail Teterin <mi@FreeBSD.org> ---
The following change makes the failure to freeze the shared memory non-fata=
l --
just as it always was:

Index: files/patch-bug1550891
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- files/patch-bug1550891      (revision 523387)
+++ files/patch-bug1550891      (working copy)
@@ -72,7 +72,7 @@
  #else
    // Generic Unix: shm_open + shm_unlink
    do {
-@@ -275,6 +282,13 @@ bool SharedMemory::Freeze() {
+@@ -275,6 +282,12 @@ bool SharedMemory::Freeze() {
      CHROMIUM_LOG(WARNING) << "failed to freeze shm: " << strerror(errno);
      return false;
    }
@@ -81,7 +81,6 @@
 +  cap_rights_init(&rights, CAP_MMAP_R);
 +  if (cap_rights_limit(mapped_file_, &rights) !=3D 0) {
 +    CHROMIUM_LOG(WARNING) << "failed to freeze shm: " << strerror(errno);
-+    return false;
 +  }
  #else
    DCHECK(frozen_file_ >=3D 0);

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-243252-21738-HM6QfBMWQ5>