From owner-freebsd-ports@FreeBSD.ORG  Tue Jul 12 23:58:26 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0BA441065675;
	Tue, 12 Jul 2011 23:58:26 +0000 (UTC)
	(envelope-from wblock@wonkity.com)
Received: from wonkity.com (wonkity.com [67.158.26.137])
	by mx1.freebsd.org (Postfix) with ESMTP id BC0A58FC15;
	Tue, 12 Jul 2011 23:58:25 +0000 (UTC)
Received: from wonkity.com (localhost [127.0.0.1])
	by wonkity.com (8.14.5/8.14.5) with ESMTP id p6CNeELV040891;
	Tue, 12 Jul 2011 17:40:14 -0600 (MDT)
	(envelope-from wblock@wonkity.com)
Received: from localhost (wblock@localhost)
	by wonkity.com (8.14.5/8.14.5/Submit) with ESMTP id p6CNeE6G040888;
	Tue, 12 Jul 2011 17:40:14 -0600 (MDT)
	(envelope-from wblock@wonkity.com)
Date: Tue, 12 Jul 2011 17:40:14 -0600 (MDT)
From: Warren Block <wblock@wonkity.com>
To: Jung-uk Kim <jkim@freebsd.org>
In-Reply-To: <201107121826.00020.jkim@FreeBSD.org>
Message-ID: <alpine.BSF.2.00.1107121731190.40818@wonkity.com>
References: <201107121826.00020.jkim@FreeBSD.org>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7
	(wonkity.com [127.0.0.1]); Tue, 12 Jul 2011 17:40:14 -0600 (MDT)
Cc: Pav Lucistnik <pav@freebsd.org>,
	Stephen Montgomery-Smith <stephen@freebsd.org>, freebsd-ports@freebsd.org
Subject: Re: [RFC] A trivial change for DESKTOP_ENTRIES
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jul 2011 23:58:26 -0000

On Tue, 12 Jul 2011, Jung-uk Kim wrote:

> After I updated x11-wm/compiz, GNOME was not able to start the window
> manager.  Basically, it complained that compiz-manager was not found.
> Then, I realized compiz-manager.desktop was automagically replaced by
> compizmanager.desktop.  Now I tracked it down to this commit:
>
> Sat Nov 27 17:42:46 2010 UTC (7 months, 2 weeks ago) by pav
>
> - DESKTOP_ENTRIES: commandline is used to name installed .desktop
> file, this can lead to files containing whitespace and funny
> characters; thus strip all non-alphanumeric characters
>
> http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk.diff?r1=1.656;r2=1.657

My fault, arising out of 
http://www.freebsd.org/cgi/query-pr.cgi?pr=147701

Additionally allowing dashes and underlines seems harmless.  Spaces and 
disallowed characters like slashes were the original concern.