Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 02 Jul 2015 18:05:40 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 201204] stable/10 mips build fails in usr.bin/gcore
Message-ID:  <bug-201204-8-ilA0VGezlU@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-201204-8@https.bugs.freebsd.org/bugzilla/>
References:  <bug-201204-8@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201204

--- Comment #1 from na@rtfm.net ---
Based on a grep for that symbol, I think it's pretty certain that the tiny
patch below is correct. Any chance we can fix this before 10.2-RELEASE?

The complete grep:

./sys/arm/include/elf.h:#define    ELF_MACHINE_OK(x) ((x) == EM_ARM)
./sys/ia64/include/elf.h:#define    ELF_MACHINE_OK(x) ((x) == EM_IA_64)
./sys/mips/include/elf.h:#define    ELF_MACHINE_OK(x) ((x) == EM_MIPS)
./sys/powerpc/include/elf.h:#define    ELF_MACHINE_OK(x) ((x) == EM_PPC64)
./sys/powerpc/include/elf.h:#define    ELF_MACHINE_OK(x) ((x) == EM_PPC)
./sys/sparc64/include/elf.h:#define    ELF_MACHINE_OK(x)    ((x) == ELF_ARCH)
./sys/x86/include/elf.h:#define    ELF_MACHINE_OK(x) ((x) == EM_386 || (x) ==
EM_486)
./sys/x86/include/elf.h:#define    ELF_MACHINE_OK(x) ((x) == EM_X86_64)
./usr.bin/gcore/elfcore.c:    if (!ELF_MACHINE_OK(machine))

And the (obvious?) patch:

Index: sys/mips/include/elf.h
===================================================================
--- sys/mips/include/elf.h    (revision 285049)
+++ sys/mips/include/elf.h    (working copy)
@@ -77,6 +77,8 @@
 #define ELF_ARCH    EM_MIPS
 #define ELF_ARCH32    EM_MIPS

+#define    ELF_MACHINE_OK(x) ((x) == EM_MIPS)
+
 /* Define "machine" characteristics */
 #if __ELF_WORD_SIZE == 32
 #define    ELF_TARG_CLASS    ELFCLASS32

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-201204-8-ilA0VGezlU>