Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 Sep 2002 17:51:17 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Peter Wemm <peter@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject:   Re: cvs commit: src/sys/sys cdefs.h
Message-ID:  <20020923174125.O16983-100000@gamplex.bde.org>
In-Reply-To: <200209230637.g8N6bs92050122@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 22 Sep 2002, Peter Wemm wrote:

> peter       2002/09/22 23:37:51 PDT
>
>   Modified files:
>     sys/sys              cdefs.h
>   Log:
>   Alfred got me thinking.  Provide stubs for lint, and let the compilers
>   themselves cause a failure if it is told to use a __widget that there is
>   no implementation for them.  missing an implementation for __unused etc is
>   harmless.  But not having a __packed implementation when the kernel code
>   really needs it is a big deal.
>
>   Revision  Changes    Path
>   1.66      +11 -5     src/sys/sys/cdefs.h

Providing stubs for lint is wrong when the non-stubs affects the
semantics of the program, as they do for the new attributes both not
for most of the old ones.  Lint should fail in the same way as the
compiler that it is linting for, and there must be no ifdefs for lint
in cdefs.h (`lint' is in the application namespace, so it must not
affect any standard header).  A lint that lints gcc code must obviously
declare __GNUC__ and __GNUC_MINOR__ for the version of gcc that it
supports, since otherwise it would not see the same things as that
version of gcc.

Style bugs in revs 1.63-1.66: the new definitions are unsorted.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020923174125.O16983-100000>