From owner-cvs-all  Tue Apr 11  9:45:43 2000
Delivered-To: cvs-all@freebsd.org
Received: from ms.tokyo.jcom.ne.jp (ms.tokyo.jcom.ne.jp [210.234.123.18])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6E30137B505; Tue, 11 Apr 2000 09:45:38 -0700 (PDT)
	(envelope-from knu@idaemons.org)
Received: from daemon.local.idaemons.org (pc343042.tokyo.jcom.ne.jp [203.140.143.42])
	by ms.tokyo.jcom.ne.jp (8.9.1/3.7W 03/13/00) with ESMTP id BAA23859;
	Wed, 12 Apr 2000 01:45:03 +0900 (JST)
Received: by daemon.local.idaemons.org (8.9.3/3.7W) id BAA81486; Wed, 12 Apr 2000 01:44:31 +0900 (JST)
Date: Wed, 12 Apr 2000 01:44:29 +0900
Message-ID: <86bt3gk2oi.wl@archon.local.idaemons.org>
From: "Akinori -Aki- MUSHA" <knu@idaemons.org>
To: imura@af.airnet.ne.jp
Cc: asami@FreeBSD.org, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: ports/chinese Makefile.inc ports/german Makefile.inc         ports/japanese Makefile.inc ports/korean Makefile.inc         ports/russian Makefile.inc ports/vietnamese Makefile.inc
In-Reply-To: In your message of "Wed, 12 Apr 2000 00:57:30 +0900"
	<20000412005730F.imura@cs.titech.ac.jp>
References: <86hfd9rzkz.wl@archon.local.idaemons.org>
	<86d7nxrtbj.wl@archon.local.idaemons.org>
	<vqc4s99ox22.fsf@silvia.hip.berkeley.edu>
	<20000412005730F.imura@cs.titech.ac.jp>
User-Agent: Wanderlust/1.1.1 (Purple Rain) EMIKO/1.13.12 (Euglena sociabilis) FLIM/1.13.2 (Kasanui) APEL/10.2 MULE XEmacs/21.1 (patch 9) (Canyonlands) (i386--freebsd)
Organization: Associated I. Daemons
X-PGP-Public-Key: finger knu@FreeBSD.org
X-PGP-Fingerprint: 1BEF D9B2 BABD 25D7 659A  FD08 89C2 F3BE E981 4E16
MIME-Version: 1.0 (generated by EMIKO 1.13.12 - "Euglena sociabilis")
Content-Type: text/plain; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

At Wed, 12 Apr 2000 00:57:30 +0900,
imura wrote:
> > +.if ${MASTERDIR} != ${.CURDIR} && exists(${.CURDIR}/../Makefile.inc)
> > +.include "${.CURDIR}/../Makefile.inc"
> > +.endif
> > +
> >  .if exists(${MASTERDIR}/../Makefile.inc)
> >  .include "${MASTERDIR}/../Makefile.inc"
> >  .endif
> 
> Why not just do like this?
> 
> .if exists(${.CURDIR}/../Makefile.inc)
> .include "${.CURDIR}/../Makefile.inc"
> .endif

I'm not sure what you're suggesting.

1) You mean a port should not include ${MASTERDIR}/../Makefile.inc?
But we need to include it to have some category specific settings in
future.

2) You mean a port should not check if ${MASTERDIR} != ${.CURDIR}?
But we need to check it in order never to include a file twice.
Imagine a case when a slave and the master were in the same category.

> >  * I think it'd be bad if every slave port were to be forced to include
> >  * `${.CURDIR}/../Makefile.inc' for itself before including
> >  * `${MASTERDIR}/Makefile', so I'd suggest we prepare some files as
> >  * follows:
> 
> I don't understand this part.
> 
> For example, korean/Wnn:
> 
> 1. Read korean/Wnn/Makefile
> 2. Read ${MASTERDIR(= japanese/Wnn)/Makefile
> 3. Read Mk/bsd.port.pre.mk
> 4. Read ${.CURDIR(= korean/Wnn)}/../Makefile.inc
> 5. Return to ${MASTERDIR}/Makefile
> 6. Read Mk/bsd.port.post.mk
> 
> So, I think, including ${.CURDIR}/../Makefile.inc before
> including ${MASTERDIR}/Makefile never occurs.

We need to include both ${.CURDIR}/../Makefile.inc and
${MASTERDIR}/../Makefile.inc (in the order named) for the reason I
mentioned above in 1).

-- 
                           /
                          /__  __
                         / )  )  ) )  /
Akinori -Aki- MUSHA aka / (_ /  ( (__(  <knu@idaemons.org>

"If you choose not to decide you still have made a choice."


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message