Date: Fri, 11 Jan 2019 22:59:34 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 234888] ports-mgmt/portlint: overeager "WARN: Makefile: X appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE" Message-ID: <bug-234888-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234888 Bug ID: 234888 Summary: ports-mgmt/portlint: overeager "WARN: Makefile: X appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE" Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: marcus@FreeBSD.org Reporter: gerald@FreeBSD.org CC: andreast@FreeBSD.org Flags: maintainer-feedback?(marcus@FreeBSD.org) Assignee: marcus@FreeBSD.org Recently portlint started to issue the following warnings in most of my lang/gcc* ports such as lang/gcc7: WARN: Makefile: MULTILIB appears in PORT_OPTIONS:M, but is not listed in= =20=20=20 OPTIONS_DEFINE If we look at lang/gcc7/Makefile we find OPTIONS_DEFINE=3D BOOTSTRAP GRAPHITE : .if exists(/usr/lib32/libc.so) OPTIONS_DEFINE_powerpc64+=3D MULTILIB : so the later .if ${ARCH} =3D=3D powerpc64 && ${PORT_OPTIONS:MMULTILIB} ${MKDIR} ${STAGEDIR}${TARGLIB32}/gcc${SUFFIX} ${MV} ${STAGEDIR}${PREFIX}/lib/lib32/*${STAGEDIR}${TARGLIB32}/gcc${SUFFIX} .endif should be fine.=20=20 (Well, technically the two .if-s do not feature exactly the same condition, but I bet portlint would warn in any case.) Suggested approach: combine the contents of *all* OPTIONS_DEFINE* statements and use that superset for this warning. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234888-7788>