From owner-freebsd-net@FreeBSD.ORG Fri Sep 27 13:10:58 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9147ED55; Fri, 27 Sep 2013 13:10:58 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wg0-x230.google.com (mail-wg0-x230.google.com [IPv6:2a00:1450:400c:c00::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 06CA12C33; Fri, 27 Sep 2013 13:10:57 +0000 (UTC) Received: by mail-wg0-f48.google.com with SMTP id n12so2658954wgh.15 for ; Fri, 27 Sep 2013 06:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=CnHqp5m+uzPFDFMt7aPvnGuk5vdXRuB6OA9koDoZbLw=; b=k0krTpbp+Be9HvP36MFuZx4POU64SQUT+jbj33NwqfEzH8RU502hE+J2UVGTh/LBMg 3x/kdk6Se0K9qe3Z62c6gUWWvUqHhaKjPTjsL6BVUIiHF0o3n7QoAZZDJUyJBnRaMDuo a5sPAoYsIaOfVCT1JS3F7y524IEMbnqcK8y3vW682ODyIiXW+UsovNPI7FKWy9Ek0Qfk fl50SBbU5XumF5S5QUnbiJ/Pz7jjUqVAOunwobVL7Foz50vhSEKnIn3sxoP8BelvQWls iMly4JalrrXFSnO7MDXxXYPeZBdjPE0b0GKDhqQItRgm5eVLwLs4Hio0uHCWzFoFmhOw IJUA== MIME-Version: 1.0 X-Received: by 10.180.10.136 with SMTP id i8mr2612895wib.46.1380287456362; Fri, 27 Sep 2013 06:10:56 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.216.73.133 with HTTP; Fri, 27 Sep 2013 06:10:56 -0700 (PDT) In-Reply-To: <52455949.5070501@freebsd.org> References: <52455949.5070501@freebsd.org> Date: Fri, 27 Sep 2013 06:10:56 -0700 X-Google-Sender-Auth: OxbRwQwCIubvn5Z5AJmEsQjUPJY Message-ID: Subject: Re: Adding Flow Director sysctls to ixgbe(4) From: Adrian Chadd To: Julian Elischer Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Takuya ASADA , "freebsd-net@freebsd.org" , hiren panchasara X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Sep 2013 13:10:58 -0000 On 27 September 2013 03:09, Julian Elischer wrote: > On 9/27/13 4:53 PM, Adrian Chadd wrote: > >> I don't care about whether there's a generic API right now. I'd rather see >> it done as a staged thing, but _not_ sysctls. >> >> Having sysctls to add/remove entries from things is just plain evil. >> >> I'd rather instead come up with a device specific ioctl API for this for >> now w/ a userland tool for each particular chip. Then once we all get a >> bit >> more experience doing this, a unified API can be proposed. >> > > that makes it worse > If you want to put a device specific sysctl/ioctl set out there then have > a device INDEPENDENT > tool that knows how to handle the devices we have modified and when we > have enough examples we can change the > ioctl/sysctl interface to a generic one without changing the interface > people are using in their scripts. > I agree that's the eventual goal, sure. But there's not necessarily a clear-cut set of shared behaviour that a generic API could actually use. That's why I'm a fan of doing it in a couple of stages - get the device-specific stuff into the tree, get that stuff debugged, then sit down in the future and figure out what the sane intersection of this. The shared API may be partly "shared overlapping behaviour"and may partly be "have a capabilities api that defines which parts of the behaviour is supported by the NIC." Thanks, -adrian