From owner-freebsd-hackers@freebsd.org Thu Apr 16 16:59:49 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9D41D2C1F24 for ; Thu, 16 Apr 2020 16:59:49 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4935786wFpz3HZ1 for ; Thu, 16 Apr 2020 16:59:48 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (v-critter.freebsd.dk [192.168.55.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by phk.freebsd.dk (Postfix) with ESMTPS id 4E1FC1AF106; Thu, 16 Apr 2020 16:59:43 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.15.2/8.15.2) with ESMTPS id 03GGxgF7025033 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 16 Apr 2020 16:59:42 GMT (envelope-from phk@critter.freebsd.dk) Received: (from phk@localhost) by critter.freebsd.dk (8.15.2/8.15.2/Submit) id 03GGxgpd025032; Thu, 16 Apr 2020 16:59:42 GMT (envelope-from phk) To: Eugene Grosbein cc: Wojciech Puchar , freebsd-hackers@freebsd.org Subject: Re: fsck parallel check In-reply-to: <571d8b81-f4f9-d371-6cf2-2e7aeb82a09b@grosbein.net> From: "Poul-Henning Kamp" References: <571d8b81-f4f9-d371-6cf2-2e7aeb82a09b@grosbein.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <25030.1587056382.1@critter.freebsd.dk> Content-Transfer-Encoding: quoted-printable Date: Thu, 16 Apr 2020 16:59:42 +0000 Message-ID: <25031.1587056382@critter.freebsd.dk> X-Rspamd-Queue-Id: 4935786wFpz3HZ1 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of phk@critter.freebsd.dk designates 130.225.244.222 as permitted sender) smtp.mailfrom=phk@critter.freebsd.dk X-Spamd-Result: default: False [-1.95 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.994,0]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.dk]; NEURAL_HAM_LONG(-1.00)[-0.998,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(0.04)[ip: (0.06), ipnet: 130.225.0.0/16(0.08), asn: 1835(0.09), country: EU(-0.01)]; FORGED_SENDER(0.30)[phk@phk.freebsd.dk,phk@critter.freebsd.dk]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:1835, ipnet:130.225.0.0/16, country:EU]; FROM_NEQ_ENVFROM(0.00)[phk@phk.freebsd.dk,phk@critter.freebsd.dk]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2020 16:59:49 -0000 -------- In message <571d8b81-f4f9-d371-6cf2-2e7aeb82a09b@grosbein.net>, Eugene Gro= sbein writes: >Not necessary. Fsck tries to parse device name this way: /path/to/nameNUM= BERrest >so it skips all chars upto last /, then extracts "name" part not containi= ng any digits, >then extracts NUMBER part containing only digits, upto maximum lenght. >Then is uses nameNUMBER for "disk name". Yeah, that part sucks... I think it would make sense to make the heuristic that if there are any entries with pass > 2, then ignore the "disk name" and simply run all entries for each pass number in parallel, trusting root to have it figured out. If the highest passnumber is 2, retain the "disk name" heuristic. -- = Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe = Never attribute to malice what can adequately be explained by incompetence= .