From owner-freebsd-ports@FreeBSD.ORG Sat Aug 20 10:42:58 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 068A41065670; Sat, 20 Aug 2011 10:42:58 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f172.google.com (mail-iy0-f172.google.com [209.85.210.172]) by mx1.freebsd.org (Postfix) with ESMTP id B5CD18FC08; Sat, 20 Aug 2011 10:42:57 +0000 (UTC) Received: by iye7 with SMTP id 7so13202956iye.17 for ; Sat, 20 Aug 2011 03:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=i7zv7kO3WF55SwGwv4YjI6a8AtRYHV0bTn1Q5rEi4QM=; b=FPZZYPUCpsbphoNmXwFk59wwINUVs2BEQgs+jCIsDZwm8HWhu/NEqaqiGp4aCzDFSi 0XtD2isbsOJ826gKPLmNKpai+/Hxiau5/PD0VteapSTxrIHvXRfLSOtlhQuHi/1n6JZX jmXVv+8Oegi+mm5AYuNGTANzRKrNYGiQt9Q3Y= Received: by 10.42.79.206 with SMTP id s14mr439691ick.348.1313836977056; Sat, 20 Aug 2011 03:42:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.182.77 with HTTP; Sat, 20 Aug 2011 03:42:27 -0700 (PDT) In-Reply-To: <4e4f3c65.SWjpvhhzZjBepdJu%perryh@pluto.rain.com> References: <201108171436.p7HEaNYQ071778@fire.js.berklix.net> <20110817161554.GA2496@lonesome.com> <4e4cc750.GqJImeHzdv6k8zld%perryh@pluto.rain.com> <4E4CBBEE.4040302@FreeBSD.org> <4e4f3c65.SWjpvhhzZjBepdJu%perryh@pluto.rain.com> From: Chris Rees Date: Sat, 20 Aug 2011 11:42:27 +0100 Message-ID: To: perryh@pluto.rain.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: mandree@freebsd.org, freebsd-ports@freebsd.org Subject: Re: sysutils/diskcheckd needs fixing and a maintainer X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Aug 2011 10:42:58 -0000 On 20 August 2011 05:47, wrote: >=A0I've been running it for a little less than > two days now, on a drive which contains a gmirror, and have yet > to see it misbehave. =A0(The HDD indicator does stay on, but this is > not surprising given that, as noted above, diskcheckd is expected > to run continuously.) Thank you very much for taking the time to investigate. >> > Do we need a "think twice before adding a port" habit? >> >> Yes. Of course, these aren't pointless ports however; while >> still developed and maintained they were once useful. > > IIUC, diskcheckd started out in base and was later moved to ports > (for reasons that are not obvious). =A0I can't see that it is any > less useful now than when first developed, or when moved from base > to ports. > >> It's time to go when they break and bitrot. > > For some definition of "break and bitrot." =A0Again, I haven't > seen any actual breakage. =A0diskcheckd could use a little tweaking, > e.g. diskcheckd.conf.sample contains a stale reference to "the > diskcheckd.conf(5) manual page" which was presumably missed when > diskcheckd was moved to ports; it should now be "the diskcheckd(8) > manual page". > > BTW how does one go about fixing a FreeBSD-native port like this? > Since we are the upstream, it would make more sense to revise the > distfile than to add a patch in the port. =A0I didn't find any mention > of this in the Porter's Handbook. > This is an unusual case where the sources are kept in the files/ subdir of the port's directory-- nowadays we'd put it in a separate distfile. However, for this case please feel free to submit a diff to the sources there and they can stay as long as the port remains useful. If you can't reproduce the problem I'll ask the submitter of ports/143566 if he still can. Is it logging to syslog? Also, would you be happy to take maintainership of this port? Chris --=20 Chris Rees =A0 =A0 =A0 =A0 =A0| FreeBSD Developer crees@FreeBSD.org =A0 | http://people.freebsd.org/~crees