From owner-freebsd-ports-bugs@FreeBSD.ORG  Sat Aug 21 16:30:30 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4C4C516A4CE
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sat, 21 Aug 2004 16:30:30 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B6DA543D5E
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sat, 21 Aug 2004 16:30:19 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i7LGUJWX050982	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Sat, 21 Aug 2004 16:30:19 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i7LGUJUt050981;
	Sat, 21 Aug 2004 16:30:19 GMT
	(envelope-from gnats)
Date: Sat, 21 Aug 2004 16:30:19 GMT
Message-Id: <200408211630.i7LGUJUt050981@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: "Sergey S. Kostyliov" <rathamahata@ehouse.ru>
Subject: Re: ports/70699: Typo in ports/devel/libedit, possible buffer
	overflow in libedit/history.c:history_save()
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: "Sergey S. Kostyliov" <rathamahata@ehouse.ru>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Aug 2004 16:30:30 -0000

The following reply was made to PR ports/70699; it has been noted by GNATS.

From: "Sergey S. Kostyliov" <rathamahata@ehouse.ru>
To: freebsd-gnats-submit@FreeBSD.org, rathamahata@ehouse.ru
Cc:  
Subject: Re: ports/70699: Typo in ports/devel/libedit, possible buffer overflow in libedit/history.c:history_save()
Date: Sat, 21 Aug 2004 20:24:20 +0400

 Otto Moerbeek <otto@drijf.net>
 has just pointed out that the:
         max_size = (len + 1023) & ~1023;
 patch is not enough (see http://www.sigmasoft.com/cgi-bin/wilma_hiliter/openbsd-bugs/200408/msg00092.html)
 
 "... If 
 len is a multiple of 1024, 
 
 max_size = (len + 1023) & ~1023;
 
 wil not increase it. Should probably be
 
 max_size = (len + 1024) & ~1023;"
 
 It looks like his statement is correct and either his patch or something like:
         http://www.sigmasoft.com/cgi-bin/wilma_hiliter/openbsd-bugs/200408/msg00096.html
 (which is a bit more intrusive but seems more self documented to me) is needed.
 
 -- 
 Sergey S. Kostyliov <rathamahata@ehouse.ru>
 Jabber ID: rathamahata@jabber.org