Date: Fri, 1 Dec 2000 00:22:35 -0700 From: "Kenneth D. Merry" <ken@kdm.org> To: Bosko Milekic <bmilekic@technokratis.com> Cc: Andrew Gallatin <gallatin@cs.duke.edu>, arch@FreeBSD.ORG, alfred@FreeBSD.ORG Subject: Re: zero copy code review Message-ID: <20001201002235.D10772@panzer.kdm.org> In-Reply-To: <Pine.BSF.4.21.0011302159210.79831-100000@jehovah.technokratis.com>; from bmilekic@technokratis.com on Thu, Nov 30, 2000 at 10:18:43PM -0500 References: <14886.63486.157224.937225@grasshopper.cs.duke.edu> <Pine.BSF.4.21.0011302159210.79831-100000@jehovah.technokratis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 30, 2000 at 22:18:43 -0500, Bosko Milekic wrote: > On Thu, 30 Nov 2000, Andrew Gallatin wrote: > > [...] > > <... some helpful comments deleted ....> > > > > Many of your comments are directly related to -current, I > > think I'll let Ken address them... > > Another one directly related to -CURRENT: > > I just noticed that the uipc_jumbo.c stuff does not do any locking. > Perhaps it would be nice to lock the code sooner or later. I would be > willing to go over it and do it but, as I said, I am really not going to > be able to do much until 2 weeks from now. It does have spls in the right places, in this case splimp() and splvm(). Would you just convert those to the proper mutexes, or are we going to go with per-data-structure mutexes (i.e. a little finer granularity), or...? (I don't know much about the mutex strategy we're using...) > Furthermore, I wonder if Alfred is gutsy enough ( :-) ) to raise his > voice and let us know how much this may interefere with the adding of > locks to sockets in the uipc subsystem, and possibly the stack as well. > Alfred, where are the potential problems? (As you've already written a > portion of the latter, I assume you're very well aware)... Hopefully it won't cause many problems.. Ken -- Kenneth Merry ken@kdm.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001201002235.D10772>