Date: Sun, 17 Sep 2017 16:52:24 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 222375] [linux][linsysfs] Support for libdrm/Mesa Message-ID: <bug-222375-8-KgYu2NzJgh@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-222375-8@https.bugs.freebsd.org/bugzilla/> References: <bug-222375-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222375 --- Comment #1 from Conrad Meyer <cem@freebsd.org> --- Patch mostly looks good to me. I'd remove the useless comments above fillers for the simple data/device/vendor/etc ones (but keep for uevent_foo and vgapci). I'd replace strncpy() in linsysfs_fill_vgapci with strlcpy(). I don't think this routine behaves correctly at the limit due to strncpy() and the "%s" format string use. (Also, strncpy() unnecessarily zero-fills the remainder of the buffer, which isn't needed on every loop iteration.) This module should use its own malloc type, rather than M_TEMP, but that matches the existing pattern so it doesn't need to be changed. Indentation seems funky on line 351 in the new file, but that might just be bugzilla. MAXPATHLEN is hugely excessive for chardevname. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-222375-8-KgYu2NzJgh>