Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Nov 2018 10:06:41 +0000
From:      bugzilla-noreply@freebsd.org
To:        net@FreeBSD.org
Subject:   [Bug 227720] Kernel panic in ppp server
Message-ID:  <bug-227720-7501-vru9OeYJPv@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-227720-7501@https.bugs.freebsd.org/bugzilla/>
References:  <bug-227720-7501@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227720

--- Comment #45 from Franck Rousseau <Franck.Rousseau@imag.fr> ---
(In reply to Andrey V. Elsukov from comment #44)

[/usr/src]# svnlite info
Path: .
Working Copy Root Path: /usr/src
URL: https://svn.freebsd.org/base/releng/11.2
Relative URL: ^/releng/11.2
Repository Root: https://svn.freebsd.org/base
Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
Revision: 341162
Node Kind: directory
Schedule: normal
Last Changed Author: gordon
Last Changed Rev: 341093
Last Changed Date: 2018-11-27 20:45:25 +0100 (Tue, 27 Nov 2018)

[/usr/src]# svnlite diff
Index: sys/amd64/conf/GENERIC
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/amd64/conf/GENERIC      (revision 341162)
+++ sys/amd64/conf/GENERIC      (working copy)
@@ -82,6 +82,8 @@
 # Debugging support.  Always need this:
 options        KDB                     # Enable kernel debugger support.
 options        KDB_TRACE               # Print a stack trace for a panic.
+options         DDB                     # Support DDB.
+options         GDB                     # Support remote GDB.

 # Make an SMP-capable kernel by default
 options        SMP                     # Symmetric MultiProcessor Kernel
Index: sys/net/if.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/net/if.c        (revision 341162)
+++ sys/net/if.c        (working copy)
@@ -1032,6 +1032,8 @@
                if (iter =3D=3D ifp) {
                        TAILQ_REMOVE(&V_ifnet, ifp, if_link);
                        found =3D 1;
+                       if (!vmove)
+                               ifp->if_flags |=3D IFF_DYING;
                        break;
                }
        IFNET_WUNLOCK();
Index: sys/net/rtsock.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/net/rtsock.c    (revision 341162)
+++ sys/net/rtsock.c    (working copy)
@@ -1555,7 +1555,7 @@
        info.rti_info[RTAX_NETMASK] =3D rtsock_fix_netmask(rt_key(rt),
            rt_mask(rt), &ss);
        info.rti_info[RTAX_GENMASK] =3D 0;
-       if (rt->rt_ifp) {
+       if (rt->rt_ifp && !(rt->rt_ifp->if_flags & IFF_DYING)) {
                info.rti_info[RTAX_IFP] =3D rt->rt_ifp->if_addr->ifa_addr;
                info.rti_info[RTAX_IFA] =3D rt->rt_ifa->ifa_addr;
                if (rt->rt_ifp->if_flags & IFF_POINTOPOINT)
@@ -1913,8 +1913,10 @@
                        rnh =3D rt_tables_get_rnh(fib, i);
                        if (rnh !=3D NULL) {
                                RIB_RLOCK(rnh);=20
+                               IFNET_RLOCK_NOSLEEP();
                                error =3D rnh->rnh_walktree(&rnh->head,
                                    sysctl_dumpentry, &w);
+                               IFNET_RUNLOCK_NOSLEEP();
                                RIB_RUNLOCK(rnh);
                        } else if (af !=3D 0)
                                error =3D EAFNOSUPPORT;

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-227720-7501-vru9OeYJPv>